[PATCH 09/10] dtoc: update dtb_platdata to support cd-gpios

Walter Lozano walter.lozano at collabora.com
Mon Jun 8 18:01:41 CEST 2020


Hi Simon

On 4/6/20 12:59, Simon Glass wrote:
> On Fri, 29 May 2020 at 12:15, Walter Lozano <walter.lozano at collabora.com> wrote:
>> Currently dtoc does not support the property cd-gpios used to declare
>> the gpios for card detect in mmc.
>>
>> This patch adds support to cd-gpios property.
>>
>> Signed-off-by: Walter Lozano <walter.lozano at collabora.com>
>> ---
>>   tools/dtoc/dtb_platdata.py | 13 ++++++++-----
>>   tools/dtoc/test_dtoc.py    |  2 +-
>>   2 files changed, 9 insertions(+), 6 deletions(-)
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> But I think you should mention GPIOs, rather than just cd-gpios, as it
> seems this will add support for any GPIO.

Sorry, probably I am missing something, but in order to support GPIOs in 
general we need to support a set of properties such as "cs-gpios", 
"rb-gpios", "gpios" among others.

Do you agree?


Regards,

Walter



More information about the U-Boot mailing list