[PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

Sean Anderson seanga2 at gmail.com
Mon Jun 8 19:05:21 CEST 2020


On 6/8/20 2:24 AM, Michal Simek wrote:
> It is in u-boot mainline from February. Then we had to fix it in April.

Do you have a link/commit hash for said fix?

> In the middle of this I have seen IIC one patchset which improves hex
> handling which is likely better way then this.

Same for this.

> I am fine with reverting this patch but I would also like to see more
> comments in the code to say that we shouldn't really change this.

This seems like a larger issue. There is a lot of code in U-Boot
implementing the C standard library, especially the string library.
Should we have a comment in each file which says something like "The
functions here implement the C standard, think carefully before making
semantic changes"?

--Sean


More information about the U-Boot mailing list