[PATCH v2 07/10] gpio: dw: Return output value when direction is out

Tan, Ley Foon ley.foon.tan at intel.com
Tue Jun 9 03:20:59 CEST 2020



> -----Original Message-----
> From: Sean Anderson <seanga2 at gmail.com>
> Sent: Monday, June 8, 2020 9:27 AM
> To: u-boot at lists.denx.de
> Cc: Tom Rini <trini at konsulko.com>; Bin Meng <bmeng.cn at gmail.com>;
> Rick Chen <rickchen36 at gmail.com>; Simon Glass <sjg at chromium.org>;
> Sean Anderson <seanga2 at gmail.com>; Anatolij Gustschin <agust at denx.de>;
> Tan, Ley Foon <ley.foon.tan at intel.com>; Marek Vasut <marex at denx.de>;
> Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> Subject: [PATCH v2 07/10] gpio: dw: Return output value when direction is
> out
> 
> dm_gpio_ops.get_value can be called when the gpio is either input or output.
> The current dw code always returns the input value, which is invalid if the
> direction is set to out.
> 
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
> This patch was previously submitted as part of
> https://patchwork.ozlabs.org/project/uboot/list/?series=161576
> 
> Changes in v2:
> - Reorder changes to minimize diff
> 
>  drivers/gpio/dwapb_gpio.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com>


More information about the U-Boot mailing list