[PATCH 1/7] Revert "mmc: zynq: parse dt when probing"

[Jaehoon Chung]

Hi,

On 6/8/20 10:16 PM, Michal Simek wrote:
> On 27. 05. 20 8:44, Jaehoon Chung wrote:
>> Hi
>>
>> On 5/22/20 7:44 PM, Michal Simek wrote:
>>> From: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
>>>
>>> This reverts commit 942b5fc03218d1c94468fc658e7dec65dabcc830.
>>>
>>> This is partial revert of the above commit.
>>>
>>> mmc_of_parse() is reading no-1-8-v from device tree and if set,
>>> it is clearing the UHS speed capabilities of cfg->host_caps.
>>> cfg->host_caps &= ~(UHS_CAPS | MMC_MODE_HS200 |
>>> 		    MMC_MODE_HS400 | MMC_MODE_HS400_ES);
>>>
>>> This is still missing to clear UHS speeds like SDHCI_SUPPORT_SDR104,
>>> SDHCI_SUPPORT_SDR50 and SDHCI_SUPPORT_DDR50.
>>>
>>> Even if we clear the flags SDHCI_SUPPORT_XXX in mmc_of_parse(),
>>> these speed flags are getting set again in cfg->host_caps in
>>> sdhci_setup_cfg().
>>>
>>> The reason for this is, SDHCI_SUPPORT_XXX flags are cleared
>>> only if controller is not capable of supporting MMC_VDD_165_195 volts.
>>>
>>> if (caps & SDHCI_CAN_VDD_180)
>>> 	cfg->voltages |= MMC_VDD_165_195;
>>>
>>> if (!(cfg->voltages & MMC_VDD_165_195))
>>> 	caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 |
>>> 		    SDHCI_SUPPORT_DDR50);
>>
>> I don't have a target to test with zynq_sdhci.
>> If there is no effect no-1-8-v property, i think that it needs to fix main problem.
>> I will check about this.
> 
> Have you had any time to take a look at it?
Sorry for late. I think it was similar issue on my environment. 
I will share result within this week. 
If it's urgent, then after merging i will find solution to fix it.

Best Regards,
Jaehoon Chung

> 
> Thanks,
> Michal
>