[PATCH u-boot 2/4] eth/r8152: reset PHY after setting it

Marek Vasut marex at denx.de
Wed Jun 10 13:06:54 CEST 2020


On 6/10/20 11:47 AM, Hayes Wang wrote:
> Marek Vasut [mailto:marex at denx.de]
>> Sent: Tuesday, June 09, 2020 10:22 PM
> [...]
>>> -		bmcr = BMCR_ANENABLE | BMCR_ANRESTART;
>>> +		bmcr = BMCR_ANENABLE | BMCR_ANRESTART | BMCR_RESET;
>>
>> Do you really need to reset a PHY while resetting the autonegotiation ?
>> I think if you reset the PHY , then the ANEG operation is restarted by
>> default or undefined, no ?
> 
> The setting is from the HW engineer. And I follow
> the rule for a long time. I think they know what
> they do.

If the hardware is OK with it, then that's fine.


More information about the U-Boot mailing list