[PATCHv3 13/15] configs: P1010RDB: Enable DM_ETH config

Z.q. Hou zhiqiang.hou at nxp.com
Mon Jun 15 10:53:37 CEST 2020


Hi Vladimir,

Thanks a lot for your comments!

> -----Original Message-----
> From: Vladimir Oltean [mailto:olteanv at gmail.com]
> Sent: 2020年6月13日 4:21
> To: Z.q. Hou <zhiqiang.hou at nxp.com>
> Cc: u-boot <u-boot at lists.denx.de>; Priyanka Jain <priyanka.jain at nxp.com>;
> Bin Meng <bmeng.cn at gmail.com>
> Subject: Re: [PATCHv3 13/15] configs: P1010RDB: Enable DM_ETH config
> 
> On Fri, 12 Jun 2020 at 18:23, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >
> > Enable the DM_ETH and DM_MDIO config.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > ---
> 
> I think you missed some configs. There are 28 P1010RDB configs, you updated
> only 16.

The *SECBOOT* ones are not converted to DM_ETH in this series since I don’t
know how to verify the SECBOOT. SECBOOT owner can enable the DM_ETH
directly if the SECBOOT works with DM mode.

Thanks,
Zhiqiang

> 
> > V3:
> >  - Rebase the patch, no change intended.
> >
> >  configs/P1010RDB-PA_36BIT_NAND_defconfig     | 2 ++
> >  configs/P1010RDB-PA_36BIT_NOR_defconfig      | 2 ++
> >  configs/P1010RDB-PA_36BIT_SDCARD_defconfig   | 2 ++
> >  configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 2 ++
> >  configs/P1010RDB-PA_NAND_defconfig           | 2 ++
> >  configs/P1010RDB-PA_NOR_defconfig            | 2 ++
> >  configs/P1010RDB-PA_SDCARD_defconfig         | 2 ++
> >  configs/P1010RDB-PA_SPIFLASH_defconfig       | 2 ++
> >  configs/P1010RDB-PB_36BIT_NAND_defconfig     | 2 ++
> >  configs/P1010RDB-PB_36BIT_NOR_defconfig      | 2 ++
> >  configs/P1010RDB-PB_36BIT_SDCARD_defconfig   | 2 ++
> >  configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 2 ++
> >  configs/P1010RDB-PB_NAND_defconfig           | 2 ++
> >  configs/P1010RDB-PB_NOR_defconfig            | 2 ++
> >  configs/P1010RDB-PB_SDCARD_defconfig         | 2 ++
> >  configs/P1010RDB-PB_SPIFLASH_defconfig       | 2 ++
> >  16 files changed, 32 insertions(+)
> >
> > diff --git a/configs/P1010RDB-PA_36BIT_NAND_defconfig
> > b/configs/P1010RDB-PA_36BIT_NAND_defconfig
> > index da04cab014..bd31e7c8fa 100644
> > --- a/configs/P1010RDB-PA_36BIT_NAND_defconfig
> > +++ b/configs/P1010RDB-PA_36BIT_NAND_defconfig
> > @@ -72,8 +72,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_36BIT_NOR_defconfig
> > b/configs/P1010RDB-PA_36BIT_NOR_defconfig
> > index e6edd395e7..f5c5f0ead5 100644
> > --- a/configs/P1010RDB-PA_36BIT_NOR_defconfig
> > +++ b/configs/P1010RDB-PA_36BIT_NOR_defconfig
> > @@ -54,8 +54,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_36BIT_SDCARD_defconfig
> > b/configs/P1010RDB-PA_36BIT_SDCARD_defconfig
> > index dcd606b0c2..229365a1eb 100644
> > --- a/configs/P1010RDB-PA_36BIT_SDCARD_defconfig
> > +++ b/configs/P1010RDB-PA_36BIT_SDCARD_defconfig
> > @@ -66,8 +66,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig
> > b/configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig
> > index c0800c8d7d..147198fb88 100644
> > --- a/configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig
> > +++ b/configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig
> > @@ -68,8 +68,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_NAND_defconfig
> > b/configs/P1010RDB-PA_NAND_defconfig
> > index 29ba692ca1..1f2472a338 100644
> > --- a/configs/P1010RDB-PA_NAND_defconfig
> > +++ b/configs/P1010RDB-PA_NAND_defconfig
> > @@ -71,8 +71,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_NOR_defconfig
> > b/configs/P1010RDB-PA_NOR_defconfig
> > index d8f87b5dac..35232a87fc 100644
> > --- a/configs/P1010RDB-PA_NOR_defconfig
> > +++ b/configs/P1010RDB-PA_NOR_defconfig
> > @@ -53,8 +53,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_SDCARD_defconfig
> > b/configs/P1010RDB-PA_SDCARD_defconfig
> > index 9711082529..6a46e3a253 100644
> > --- a/configs/P1010RDB-PA_SDCARD_defconfig
> > +++ b/configs/P1010RDB-PA_SDCARD_defconfig
> > @@ -65,8 +65,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PA_SPIFLASH_defconfig
> > b/configs/P1010RDB-PA_SPIFLASH_defconfig
> > index de2ac2235f..6c7c12efc1 100644
> > --- a/configs/P1010RDB-PA_SPIFLASH_defconfig
> > +++ b/configs/P1010RDB-PA_SPIFLASH_defconfig
> > @@ -67,8 +67,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_36BIT_NAND_defconfig
> > b/configs/P1010RDB-PB_36BIT_NAND_defconfig
> > index 9f4876dd13..832f7ce431 100644
> > --- a/configs/P1010RDB-PB_36BIT_NAND_defconfig
> > +++ b/configs/P1010RDB-PB_36BIT_NAND_defconfig
> > @@ -72,8 +72,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_36BIT_NOR_defconfig
> > b/configs/P1010RDB-PB_36BIT_NOR_defconfig
> > index e85af32e2c..61afaf67ac 100644
> > --- a/configs/P1010RDB-PB_36BIT_NOR_defconfig
> > +++ b/configs/P1010RDB-PB_36BIT_NOR_defconfig
> > @@ -54,8 +54,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_36BIT_SDCARD_defconfig
> > b/configs/P1010RDB-PB_36BIT_SDCARD_defconfig
> > index 45feab4ee4..8f483b4398 100644
> > --- a/configs/P1010RDB-PB_36BIT_SDCARD_defconfig
> > +++ b/configs/P1010RDB-PB_36BIT_SDCARD_defconfig
> > @@ -66,8 +66,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig
> > b/configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig
> > index 3cd94f84ea..447ef19530 100644
> > --- a/configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig
> > +++ b/configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig
> > @@ -68,8 +68,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_NAND_defconfig
> > b/configs/P1010RDB-PB_NAND_defconfig
> > index ddfe7b43a1..d8aae17e84 100644
> > --- a/configs/P1010RDB-PB_NAND_defconfig
> > +++ b/configs/P1010RDB-PB_NAND_defconfig
> > @@ -71,8 +71,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_NOR_defconfig
> > b/configs/P1010RDB-PB_NOR_defconfig
> > index 6011f8a9d8..632afeaa89 100644
> > --- a/configs/P1010RDB-PB_NOR_defconfig
> > +++ b/configs/P1010RDB-PB_NOR_defconfig
> > @@ -53,8 +53,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_SDCARD_defconfig
> > b/configs/P1010RDB-PB_SDCARD_defconfig
> > index 65f86fff60..4ba919b206 100644
> > --- a/configs/P1010RDB-PB_SDCARD_defconfig
> > +++ b/configs/P1010RDB-PB_SDCARD_defconfig
> > @@ -65,8 +65,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > diff --git a/configs/P1010RDB-PB_SPIFLASH_defconfig
> > b/configs/P1010RDB-PB_SPIFLASH_defconfig
> > index f71ee19ba6..d5b9aca56d 100644
> > --- a/configs/P1010RDB-PB_SPIFLASH_defconfig
> > +++ b/configs/P1010RDB-PB_SPIFLASH_defconfig
> > @@ -67,8 +67,10 @@ CONFIG_PHY_SMSC=y
> >  CONFIG_PHY_VITESSE=y
> >  CONFIG_PHY_GIGE=y
> >  CONFIG_E1000=y
> > +CONFIG_DM_ETH=y
> >  CONFIG_MII=y
> >  CONFIG_TSEC_ENET=y
> > +CONFIG_DM_MDIO=y
> >  CONFIG_DM_PCI=y
> >  CONFIG_DM_PCI_COMPAT=y
> >  CONFIG_PCIE_FSL=y
> > --
> > 2.25.1
> >


More information about the U-Boot mailing list