[PATCHv3 12/15] powerpc: p1010rdb: Compile legacy ethernet init function when no DM_ETH

[Z.q. Hou]

Hi Vladimir,

Thanks a lot for your comments!

> -----Original Message-----
> From: Vladimir Oltean [mailto:olteanv at gmail.com]
> Sent: 2020年6月13日 4:25
> To: Z.q. Hou <zhiqiang.hou at nxp.com>
> Cc: u-boot <u-boot at lists.denx.de>; Priyanka Jain <priyanka.jain at nxp.com>;
> Bin Meng <bmeng.cn at gmail.com>
> Subject: Re: [PATCHv3 12/15] powerpc: p1010rdb: Compile legacy ethernet
> init function when no DM_ETH
> 
> On Fri, 12 Jun 2020 at 18:23, Zhiqiang Hou <Zhiqiang.Hou at nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> >
> > The board_eth_init() is only used by legacy ethernet driver framework,
> > so do not compile it when DM_ETH config has been selected.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou at nxp.com>
> > ---
> 
> Ideally shouldn't all p1010rdb configs be converted to DM_ETH, and then
> board_eth_init can be deleted? What was the problem with the rest of the
> configs?
> 

Now the SECBOOT defconfigs are still not converted.

Thanks,
Zhiqiang

> > V3:
> >  - Rebase the patch, no change intended.
> >
> >  board/freescale/p1010rdb/p1010rdb.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/board/freescale/p1010rdb/p1010rdb.c
> > b/board/freescale/p1010rdb/p1010rdb.c
> > index 66ccc0bd1e..309f4daa88 100644
> > --- a/board/freescale/p1010rdb/p1010rdb.c
> > +++ b/board/freescale/p1010rdb/p1010rdb.c
> > @@ -484,6 +484,7 @@ int checkboard(void)
> >         return 0;
> >  }
> >
> > +#ifndef CONFIG_DM_ETH
> >  int board_eth_init(bd_t *bis)
> >  {
> >  #ifdef CONFIG_TSEC_ENET
> > @@ -524,6 +525,7 @@ int board_eth_init(bd_t *bis)
> >
> >         return pci_eth_init(bis);
> >  }
> > +#endif
> >
> >  #if defined(CONFIG_OF_BOARD_SETUP)
> >  void fdt_del_flexcan(void *blob)
> > --
> > 2.25.1
> >