[PATCH 0/2] omap4: panda: convert to device model

[Vignesh Raghavendra]

On 15/06/20 11:49 am, Tero Kristo wrote:
> On 14/06/2020 16:49, Lokesh Vutla wrote:
>> Hi Tero,
>>
>> On 02/06/20 4:49 pm, Tero Kristo wrote:
>>> Hi,
>>>
>>> As there is looming death to OMAP4 Panda board u-boot support, I decided
>>> to take a shot and convert it to device model myself. With these patches
>>> it boots up fine, and there are no DM_SPL conversion complaints during
>>> compile time anymore. I think USB ethernet does not work anymore with
>>> this, but its better than dropping the support for the board completely.
>>> USB itself appears working, so it should be relatively easy for someone
>>> to fix the networking support if they need it.
>>
>> I see the below warning with these patches:
>>
>> board/ti/panda/panda.c:329:35: warning: ‘struct ehci_hcor’ declared
>> inside parameter list will not be visible outside of this definition
>> or declaration
>>    329 |   struct ehci_hccr **hccr, struct ehci_hcor **hcor)
>>        |                                   ^~~~~~~~~
>> board/ti/panda/panda.c:329:10: warning: ‘struct ehci_hccr’ declared
>> inside parameter list will not be visible outside of this definition
>> or declaration
>>    329 |   struct ehci_hccr **hccr, struct ehci_hcor **hcor)
>>        |          ^~~~~~~~~
>> board/ti/panda/panda.c: In function ‘ehci_hcd_init’:
>> board/ti/panda/panda.c:339:8: warning: implicit declaration of
>> function ‘omap_ehci_hcd_init’; did you mean ‘ehci_hcd_init’?
>> [-Wimplicit-function-declaration]
>>    339 |  ret = omap_ehci_hcd_init(index, &usbhs_bdata, hccr, hcor);
>>        |        ^~~~~~~~~~~~~~~~~~
>>        |        ehci_hcd_init
>> board/ti/panda/panda.c: In function ‘ehci_hcd_stop’:
>> board/ti/panda/panda.c:348:9: warning: implicit declaration of
>> function ‘omap_ehci_hcd_stop’; did you mean ‘ehci_hcd_stop’?
>> [-Wimplicit-function-declaration]
>>    348 |  return omap_ehci_hcd_stop();
>>        |         ^~~~~~~~~~~~~~~~~~
>>        |         ehci_hcd_stop
> 
> Yeah, I actually see these also. I think we could maybe drop all the
> offending code as I did later with the omap5-uevm. On omap5, USB seemed
> to work even without these.
> 
> Maybe some USB expert can comment on these (Vignesh)?
> 


Offending code won't compile with DM_USB enabled. I suggest to drop them
for now in order to avoid entire board support from being dropped. USB
can be added back later if needed...

Or you would have to disable DM_USB give this a try..

Regards
Vignesh

> -Tero
> 
>>
>>
>> Thanks and regards,
>> Lokesh
>>
>>
>>>
>>> -Tero
>>>
>>>
>>> -- 
>>>
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki