U-Boot atheros PHY support and cubox ethernet

[Tom Rini]

On Tue, Jun 16, 2020 at 11:30:00PM +0200, Michael Walle wrote:
> Am 16. Juni 2020 22:21:08 MESZ schrieb Vladimir Oltean <olteanv at gmail.com>:
> >On Tue, 16 Jun 2020 at 23:10, Tom Rini <trini at konsulko.com> wrote:
> >>
> >> On Tue, Jun 16, 2020 at 10:58:26PM +0300, Vladimir Oltean wrote:
> >> > Hi Tom,
> >> >
> >> > On Tue, 16 Jun 2020 at 22:55, Tom Rini <trini at konsulko.com> wrote:
> >> > >
> >> > > Hey all,
> >> > >
> >> > > In commit 4346df3392c0 ("phy: atheros: Make RGMII Tx delays
> >actually
> >> > > configurable for AR8035") we brought in changes to get in to line
> >with
> >> > > upstream linux kernel support for this PHY and in turn deal with
> >more
> >> > > "driver was wrong, DT was wrong too" changes.  Now the problem I
> >have is
> >> > > that ethernet on my Hummingboard doesn't work AND as far as I can
> >tell,
> >> > > the DTB is correct and saying phy-mode = "rgmii-id" now not
> >"rgmii".  It
> >> > > also looks to match what's in v5.7 for the kernel.  What do I
> >need to do
> >> > > here next?  Thanks!
> >> > >
> >> > > --
> >> > > Tom
> >> >
> >> > Reverting 4346df3392c0 makes your interface work?
> >>
> >> Yup.
> >>
> >> > What is the DTS path that your hummingboard uses?
> >>
> >> Good question.  Per board/solidrun/mx6cuboxi/mx6cuboxi.c:
> >> /*
> >>  * This is not a perfect match. Avoid dependency on the DM GPIO
> >driver
> >>  * needed
> >>  * for accurate board detection. Hummingboard2 DT is good enough for
> >>  * U-Boot on
> >>  * all Hummingboard/Cubox-i platforms.
> >>  */
> >> so arch/arm/dts/imx6dl-hummingboard2-emmc-som-v15.dts is the base. 
> >But
> >> the board really is the original hummingboard platform.  Thanks!
> >>
> >> --
> >> Tom
> >
> >Does it work if you say PHY_INTERFACE_MODE_RGMII_ID here?
> >https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1232
> 
> it should be PHY_INTERFACE_MODE_RGMII_TXID to get the original behavior, shouldn't it? The commit in question only removes the hardcoded TX delay. 

This change alone also still fails on master for me.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200616/c1b2aaaf/attachment.sig>