USB patch for rpi4

[Stuart Yoder]

On Mon, Jun 15, 2020 at 4:48 AM Nicolas Saenz Julienne
<nsaenzjulienne at suse.de> wrote:
>
> On Mon, 2020-06-15 at 11:28 +0200, Sylwester Nawrocki wrote:
> > Hi,
> >
> > (Cc: Nicolas and Jim)
>
> Jim, FYI, this relates to u-boot's pcie-brcmstb implementation.
>
> > On 11.06.2020 11:18, Peter Robinson wrote:
> > > > > > I am trying to test v4 of your patch series for USB support on rpi4:
> > > > > > I am building u-boot 64-bit.  Testing on a rpi4 B 1.2 board.  But, USB
> > > > > > is
> > > > > > not working for me and wanted to see if you had any ideas.  Are there
> > > > > > other dependencies other than just applying your patch series?
> > > > > >
> > > > > > I've pasted the u-boot console output below.
> > > > > >
> > > > > > From what I can tell this board does not need the VL805 firmware
> > > > >
> > > > > 1.2 rev boards do need the firmware loading patch series, not sure
> > > > > about any other patches.
> > > >
> > > > Are you sure?  A colleague of mine said that it was in 1.4 that the flash
> > > > chip for the VL805 was removed.  I can physically see that the flash
> > > > chip is on my board.
> > >
> > > Yes, I am sure, the 1.2 is for the 2/4Gb model with the changes that
> > > need the firmware loading, the 1.4 according to their rev docs is
> > > limited to the 8Gb model ATM.
> > >
> > >
> https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
> >
> > I'm also using rev. 1.2 board and it has the flash chip mounted and doesn't
> > need the VL805 firmware loading patch series.
>
> The first comercially available board I've seen without the vl805 eeprom is the
> new 8GB variant. There should be an unpopulated chip just below the audio Jack.
>
> > > > In any case, I did figure out one thing that was going on.  I was using
> > > > the rpi4 DTB as it came shipped with my board.  I found that on the
>
> I strongly suggest you either use the Linux upstream device-tree or if not
> possible, the latest device-tree maintained by the rpi guys. For example the
> one available on their rpi-5.7.y branch.
>
> Lots has changed since they released the original device-tree and you're likely
> to run into issues like this one all over the place, if combining it with
> upstream code.

Thanks!
Stuart