[PATCH 1/2] firmware: PSCI: Fix PSCI support for OF live trees

Tom Rini trini at konsulko.com
Thu Jun 18 18:27:51 CEST 2020


On Thu, Jun 18, 2020 at 04:19:51PM +0000, Tom Warren wrote:

> No worries, I can fix it when I add them to u-boot-tegra. I have some other patches to add & generate a PR, I'll get it out by EOW.  TomR - do you want me to take this patch as well as the ARM: tegra: patch in my PR, or do you want Jon's first patch to go thru a different repo?

You can take them all, thanks!

> 
> Tom
> --
> nvpublic
> 
> -----Original Message-----
> From: Jonathan Hunter <jonathanh at nvidia.com> 
> Sent: Thursday, June 18, 2020 8:47 AM
> To: Tom Rini <trini at konsulko.com>; Tom Warren <TWarren at nvidia.com>
> Cc: Stephen Warren <swarren at nvidia.com>; Thierry Reding <treding at nvidia.com>; Peter Robinson <pbrobinson at redhat.com>; Heinrich Schuchardt <xypron.glpk at gmx.de>; u-boot at lists.denx.de
> Subject: Re: [PATCH 1/2] firmware: PSCI: Fix PSCI support for OF live trees
> 
> 
> On 18/06/2020 12:54, Jon Hunter wrote:
> > When CONFIG_OF_LIVE is enabled, dev_of_offset() cannot be used and if 
> > used returns an invalid offset. This causes the call to
> > fdt_stringlist_get() in the psci_probe() to fail to read the 'method'
> > property from the PSCI node for the device and hence prevents PSCI 
> > from working. Fix this by using the ofnode_read_string() API instead 
> > of the fdt_stringlist_get() because this will handle reading the 
> > property both when CONFIG_OF_LIVE is enabled or disabled.
> > 
> > Due to the above problem and since commit 81ea00838c68 ("efi_loader:
> > PSCI reset and shutdown") was added, the EFI system reset has been 
> > broken for Tegra210 and Tegra196 platforms. This also fixes the EFI 
> > system reset for these Tegra platforms.
> 
> Oops, just spotted the above typo. Should be Tegra186 and not Tegra196 (which does not exist!). I can correct that.
> 
> Jon
> 
> --
> nvpublic

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200618/9b3fbea6/attachment.sig>


More information about the U-Boot mailing list