[PATCH 1/4] phy: atheros: ar8035: Fix clock output calculation
Tom Rini
trini at konsulko.com
Thu Jun 18 21:26:00 CEST 2020
On Thu, Jun 18, 2020 at 04:05:21PM -0300, Fabio Estevam wrote:
> The clock ouput frequency is calculated incorrectly for AR8035 due to
> wrong masking of priv->clk_25m_reg and priv->clk_25m_mask.
>
> This same issue has been already fixed in the kernel by:
>
> commit b1f4c209d84057b6d40b939b6e4404854271d797
> Author: Oleksij Rempel <o.rempel at pengutronix.de>
> Date: Wed Apr 1 11:57:32 2020 +0200
>
> net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
>
> The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
> for the values that comprise the fields, not zero-bits-set.
>
> This patch fixes the clock frequency configuration for ATH8030 and
> ATH8035 Atheros PHYs by removing the erroneous "~".
>
> To reproduce this bug, configure the PHY with the device tree binding
> "qca,clk-out-frequency" and remove the machine specific PHY fixups.
>
> Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
> Signed-off-by: Oleksij Rempel <o.rempel at pengutronix.de>
> Reported-by: Russell King <rmk+kernel at armlinux.org.uk>
> Reviewed-by: Russell King <rmk+kernel at armlinux.org.uk>
> Tested-by: Russell King <rmk+kernel at armlinux.org.uk>
> Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Apply the same fix in the U-Boot driver.
>
> Tested on a i.MX6 Hummingboard.
>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Reviewed-by: Michael Walle <michael at walle.cc>
Tested-by: Tom Rini <trini at konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200618/afa99e64/attachment.sig>
More information about the U-Boot
mailing list