[PATCH V2 4/5] pinctrl: renesas: Enable R8A774A1 PFC tables

[Adam Ford]

On Fri, Jun 19, 2020 at 9:27 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> On 6/19/20 4:25 PM, Adam Ford wrote:
> > On Fri, Jun 19, 2020 at 9:18 AM Marek Vasut <marek.vasut at gmail.com> wrote:
> >>
> >> On 6/19/20 3:58 PM, Adam Ford wrote:
> >>> The PFC tables for the R8A774A1 are already available, but they
> >>> not enabled.
> >>>
> >>> This patch adds the Kconfig option and builds the corresponding file
> >>> when PINCTRL_PFC_R8A774A1 is enabled.
> >>
> >> [...]
> >>
> >>> diff --git a/drivers/pinctrl/renesas/sh_pfc.h b/drivers/pinctrl/renesas/sh_pfc.h
> >>> index db3d513358..b9ce471007 100644
> >>> --- a/drivers/pinctrl/renesas/sh_pfc.h
> >>> +++ b/drivers/pinctrl/renesas/sh_pfc.h
> >>> @@ -300,6 +300,7 @@ extern const struct sh_pfc_soc_info r8a7793_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a7794_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a7795_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a7796_pinmux_info;
> >>> +extern const struct sh_pfc_soc_info r8a774a1_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a77965_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a77970_pinmux_info;
> >>>  extern const struct sh_pfc_soc_info r8a77980_pinmux_info;
> >>
> >> Please keep the lists sorted, all of them, where it makes sense.
> >
> > I was trying to do that.  At least in hex. Doesn't 774a1 comes after
> > 7796 and before 77965?
>
> I honestly don't know how to sort these lists well either, neither
> option seems particularly good. What does Linux do ?

I can make it match Linux or at least place it where it would be.
Some of the entries in Linux don't exist in U-Boot, so would mean
putting this at the top of the list.

adam