[PATCH v5 4/4] usb: xhci: Add reset controller support

Marek Vasut marex at denx.de
Mon Jun 22 17:34:12 CEST 2020


On 6/22/20 5:30 PM, Nicolas Saenz Julienne wrote:
[...]

> diff --git a/include/usb/xhci.h b/include/usb/xhci.h
> index 1170c0ac69..7d34103fd5 100644
> --- a/include/usb/xhci.h
> +++ b/include/usb/xhci.h
> @@ -16,6 +16,7 @@
>  #ifndef HOST_XHCI_H_
>  #define HOST_XHCI_H_
>  
> +#include <reset.h>
>  #include <asm/types.h>
>  #include <asm/cache.h>
>  #include <asm/io.h>
> @@ -1209,6 +1210,7 @@ struct xhci_ctrl {
>  #if CONFIG_IS_ENABLED(DM_USB)
>  	struct udevice *dev;
>  #endif
> +	struct reset_ctl reset;

Should all this reset logic be protected by if CONFIG_IS_ENABLED(DM_RESET) ?

Otherwise the series looks good to me, thanks.


More information about the U-Boot mailing list