Fwd: [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c

[Brandon Maier]

Forwarding as I forgot to CC
---------- Forwarded message ---------
From: Brandon Maier <brandon.maier at rockwellcollins.com>
Date: Tue, Jun 23, 2020 at 12:08 PM
Subject: Re: [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c
To: Luca Ceresoli <luca at lucaceresoli.net>


On Tue, Jun 23, 2020 at 10:18 AM Luca Ceresoli <luca at lucaceresoli.net> wrote:
>
> Hi Brandon,
>
> On 22/06/20 22:45, Brandon Maier wrote:
> > To use CONFIG_ZYNQMP_SPL_PM_CFG_OBJ_FILE, a developer must pull down the
> > U-Boot source and run ./tools/zynqmp_pm_cfg_obj_convert.py to convert
> > their pm_cfg_obj.c into U-Boot's PMU loader format, then feed that file
> > back to U-Boot during build.
> >
> > Instead, by doing the conversion in U-Boot during the build, we can
> > simplify the developer's build system. And it ensures that if
> > zynqmp_pm_cfg_obj_convert.py is updated, the pm_cfg_obj will stay in
> > sync with U-Boot.
>
> In the workflows I have used so far U-Boot tools are extracted in a
> different step w.r.t. U-Boot cross-compilation, so I never felt the need
> for this feature. But I understand this feature can be handy.

I'm trying to get it to work with Buildroot. Buildroot does have a
package for uboot-tools, so I could use that to run it. I'd have to
move the config and build commands into Buildroot's uboot package.
Since the script belongs to U-Boot anyway, it seemed cleaner to
integrate it directly into U-Boot so it could be used by other build
systems too.

>
> The code looks OK too.
>
> Reviewed-by: Luca Ceresoli <luca at lucaceresoli.net>
>
> --
> Luca