[PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver

[Pragnesh Patel]

Hi Rick,

>-----Original Message-----
>From: Bin Meng <bmeng.cn at gmail.com>
>Sent: 24 June 2020 13:04
>To: Rick Chen <rickchen36 at gmail.com>
>Cc: Pragnesh Patel <pragnesh.patel at sifive.com>; U-Boot Mailing List <u-
>boot at lists.denx.de>; Atish Patra <atish.patra at wdc.com>;
>palmerdabbelt at google.com; Paul Walmsley ( Sifive)
><paul.walmsley at sifive.com>; Anup Patel <anup.patel at wdc.com>; Sagar
>Kadam <sagar.kadam at sifive.com>; Palmer Dabbelt <palmer at dabbelt.com>;
>Jagan Teki <jagan at amarulasolutions.com>; rick <rick at andestech.com>; Alan
>Kao <alankao at andestech.com>
>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>Hi Rick,
>
>On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <rickchen36 at gmail.com> wrote:
>>
>> Hi Bin
>>
>> > Hi Rick,
>> >
>> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel
>> > <pragnesh.patel at sifive.com> wrote:
>> > >
>> > > Hi Rick,
>> > >
>> > > >-----Original Message-----
>> > > >From: Rick Chen <rickchen36 at gmail.com>
>> > > >Sent: 24 June 2020 10:44
>> > > >To: Pragnesh Patel <pragnesh.patel at sifive.com>
>> > > >Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Atish Patra
>> > > ><atish.patra at wdc.com>; palmerdabbelt at google.com; Bin Meng
>> > > ><bmeng.cn at gmail.com>; Paul Walmsley ( Sifive)
>> > > ><paul.walmsley at sifive.com>; Anup Patel <anup.patel at wdc.com>;
>> > > >Sagar Kadam <sagar.kadam at sifive.com>; Palmer Dabbelt
>> > > ><palmer at dabbelt.com>; Jagan Teki <jagan at amarulasolutions.com>;
>> > > >rick <rick at andestech.com>; Alan Kao <alankao at andestech.com>
>> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>> > > >driver
>> > > >
>> > > >[External Email] Do not click links or attachments unless you
>> > > >recognize the sender and know the content is safe
>> > > >
>> > > >Hi Pragnesh
>> > > >
>> > > >> Hi Rick,
>> > > >>
>> > > >> >-----Original Message-----
>> > > >> >From: Rick Chen <rickchen36 at gmail.com>
>> > > >> >Sent: 24 June 2020 06:30
>> > > >> >To: Pragnesh Patel <pragnesh.patel at sifive.com>
>> > > >> >Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Atish Patra
>> > > >> ><atish.patra at wdc.com>; palmerdabbelt at google.com; Bin Meng
>> > > >> ><bmeng.cn at gmail.com>; Paul Walmsley ( Sifive)
>> > > >> ><paul.walmsley at sifive.com>; Anup Patel <anup.patel at wdc.com>;
>> > > >> >Sagar Kadam <sagar.kadam at sifive.com>; Palmer Dabbelt
>> > > ><palmer at dabbelt.com>;
>> > > >> >Jagan Teki <jagan at amarulasolutions.com>; rick
>> > > >> ><rick at andestech.com>; Alan Kao <alankao at andestech.com>
>> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>> > > >> >PWM driver
>> > > >> >
>> > > >> >[External Email] Do not click links or attachments unless you
>> > > >> >recognize the sender and know the content is safe
>> > > >> >
>> > > >> >Hi Pragnesh
>> > > >> >
>> > > >> >> From: Pragnesh Patel [mailto:pragnesh.patel at sifive.com]
>> > > >> >> Sent: Friday, May 29, 2020 2:45 PM
>> > > >> >> To: u-boot at lists.denx.de
>> > > >> >> Cc: atish.patra at wdc.com; palmerdabbelt at google.com;
>> > > >> >bmeng.cn at gmail.com; paul.walmsley at sifive.com;
>> > > >> >anup.patel at wdc.com; sagar.kadam at sifive.com; Rick Jian-Zhi
>> > > >> >Chen(陳建志); Pragnesh Patel; Palmer Dabbelt
>> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM
>> > > >> >> driver
>> > > >> >>
>> > > >> >> This patch enables SiFive PWM driver for the SiFive Unleashed
>board.
>> > > >> >>
>> > > >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
>> > > >> >> ---
>> > > >> >>  board/sifive/fu540/Kconfig | 2 ++
>> > > >> >>  1 file changed, 2 insertions(+)
>> > > >> >>
>> > > >> >> diff --git a/board/sifive/fu540/Kconfig
>> > > >> >> b/board/sifive/fu540/Kconfig index
>> > > >> >86193d7668..683668d059 100644
>> > > >> >> --- a/board/sifive/fu540/Kconfig
>> > > >> >> +++ b/board/sifive/fu540/Kconfig
>> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>> > > >> >>         imply SMP
>> > > >> >>         imply MISC
>> > > >> >>         imply SIFIVE_OTP
>> > > >> >> +       imply DM_PWM
>> > > >> >> +       imply PWM_SIFIVE
>> > > >> >>
>> > > >> >
>> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive.
>> > > >> >It is weird to introduce here and not appropriate to depend on
>> > > >> >another
>> > > >patch.
>> > > >>
>> > > >> Do you want me to send this 2 patches separately independent of
>> > > >> each
>> > > >other ?
>> > > >
>> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive
>> > > >PWM driver into [PATCH v2 0/2] Add support for PWM SiFive ?
>> > >
>> > > I am okay with it, you can go ahead and merge this patch into PWM
>series of Yash.
>> > >
>> >
>> > They are separate patches and should keep separate. I am not sure
>> > what's the issue we want to resolve?
>>
>> Nothing about resolve.
>> Logically if they can be put together, it will be more reasonable.
>
>Agree. Thanks for the clarification.
>
>That's why I recommend developers submit all related patch sets in a series to
>help maintainers' work :)

Just to clarify, you are going to merge this patch into [PATCH v2 0/2] Add support for PWM SiFive, right ?
Let me know if I am wrong and you want to resubmit anything from me.

>
>Regards,
>Bin