[PATCH] net: xilinx: axi_emac: Fix endless loop when no PHYs are connected
Michal Simek
monstr at monstr.eu
Thu Jun 25 10:06:22 CEST 2020
čt 4. 6. 2020 v 10:59 odesílatel Michal Simek <michal.simek at xilinx.com> napsal:
>
> From: Patrick van Gelder <patrick.vangelder at nl.bosch.com>
>
> The index used to iterate over the possible PHYs in axiemac_phy_init was an
> unsigned int and decremented. Therefor it was always >= 0 and never exited
> the loop.
>
> Signed-off-by: Patrick van Gelder <patrick.vangelder at nl.bosch.com>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
> drivers/net/xilinx_axi_emac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
> index d0683db80d88..2cd559676846 100644
> --- a/drivers/net/xilinx_axi_emac.c
> +++ b/drivers/net/xilinx_axi_emac.c
> @@ -244,7 +244,8 @@ static u32 phywrite(struct axidma_priv *priv, u32 phyaddress, u32 registernum,
> static int axiemac_phy_init(struct udevice *dev)
> {
> u16 phyreg;
> - u32 i, ret;
> + int i;
> + u32 ret;
> struct axidma_priv *priv = dev_get_priv(dev);
> struct axi_regs *regs = priv->iobase;
> struct phy_device *phydev;
> --
> 2.27.0
>
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
More information about the U-Boot
mailing list