[PATCH 1/5] sysreset: syscon: Don't assume default value for offset and mask property

[Pragnesh Patel]

>-----Original Message-----
>From: Bin Meng <bmeng.cn at gmail.com>
>Sent: 23 June 2020 11:00
>To: Rick Chen <rick at andestech.com>; Simon Glass <sjg at chromium.org>;
>Pragnesh Patel <pragnesh.patel at sifive.com>; Sagar Kadam
><sagar.kadam at sifive.com>; U-Boot Mailing List <u-boot at lists.denx.de>
>Cc: Bin Meng <bin.meng at windriver.com>
>Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset
>and mask property
>
>[External Email] Do not click links or attachments unless you recognize the
>sender and know the content is safe
>
>From: Bin Meng <bin.meng at windriver.com>
>
>Per the DT binding, <offset> is a required property. Let's abort the probe if it is
>missing. For the <mask> property, current codes assume a default value of
>zero, which is not correct either.
>
>Signed-off-by: Bin Meng <bin.meng at windriver.com>
>---
>
> drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Pragnesh Patel <pragnesh.patel at sifive.com>