[PATCH v5 02/14] riscv: sifive: fu540: Use OTP DM driver for serial environment variable

[Bin Meng]

On Wed, Mar 11, 2020 at 9:32 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> On Wed, Mar 11, 2020 at 3:03 PM Pragnesh Patel
> <pragnesh.patel at sifive.com> wrote:
> >
> > Use the OTP DM driver to set the serial environment variable.
> >
> > Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
> > ---
> >  arch/riscv/dts/fu540-c000-u-boot.dtsi         |  14 +++
> >  .../dts/hifive-unleashed-a00-u-boot.dtsi      |   6 +
> >  board/sifive/fu540/Kconfig                    |   2 +
> >  board/sifive/fu540/fu540.c                    | 113 +++++++-----------
> >  4 files changed, 62 insertions(+), 73 deletions(-)
> >  create mode 100644 arch/riscv/dts/fu540-c000-u-boot.dtsi
> >  create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
> >
> > diff --git a/arch/riscv/dts/fu540-c000-u-boot.dtsi b/arch/riscv/dts/fu540-c000-u-boot.dtsi
> > new file mode 100644
> > index 0000000000..31fd113c7d
> > --- /dev/null
> > +++ b/arch/riscv/dts/fu540-c000-u-boot.dtsi
> > @@ -0,0 +1,14 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * (C) Copyright 2019 SiFive, Inc
>
> nits: 2020?
>
> > + */
> > +
> > +/ {
> > +       soc {
> > +               otp: otp at 10070000 {
> > +                       compatible = "sifive,fu540-otp";
> > +                       reg = <0x0 0x10070000 0x0 0x0FFF>;
> > +                       fuse-count = <0x1000>;
>
> Add status = "disabled" here?

After reviewing patch 5 in this series, I think we can leave without
adding "status" property here.

>
> > +               };
> > +       };
> > +};
> > diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
> > new file mode 100644
> > index 0000000000..bec0d19134
> > --- /dev/null
> > +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2019 SiFive, Inc
>
> nits: 2020?
>
> > + */
> > +
> > +#include "fu540-c000-u-boot.dtsi"
>
> Add
>
> &otp {
> status = "okay";
> }
>
> here?

After reviewing patch 5 in this series, I think we can leave without
adding "status" property here.

Regards,
Bin