[PATCH v5 02/14] riscv: sifive: fu540: Use OTP DM driver for serial environment variable

[Pragnesh Patel]

Hi Bin,

>-----Original Message-----
>From: Bin Meng <bmeng.cn at gmail.com>
>Sent: 11 March 2020 20:23
>To: Pragnesh Patel <pragnesh.patel at sifive.com>
>Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Atish Patra
><atish.patra at wdc.com>; Palmer Dabbelt <palmerdabbelt at google.com>; Paul
>Walmsley <paul.walmsley at sifive.com>; Jagan Teki
><jagan at amarulasolutions.com>; Troy Benjegerdes
><troy.benjegerdes at sifive.com>; Anup Patel <anup.patel at wdc.com>; Sagar
>Kadam <sagar.kadam at sifive.com>; Rick Chen <rick at andestech.com>; Palmer
>Dabbelt <palmer at dabbelt.com>
>Subject: Re: [PATCH v5 02/14] riscv: sifive: fu540: Use OTP DM driver for serial
>environment variable
>
>On Wed, Mar 11, 2020 at 9:32 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>>
>> On Wed, Mar 11, 2020 at 3:03 PM Pragnesh Patel
>> <pragnesh.patel at sifive.com> wrote:
>> >
>> > Use the OTP DM driver to set the serial environment variable.
>> >
>> > Signed-off-by: Pragnesh Patel <pragnesh.patel at sifive.com>
>> > ---
>> >  arch/riscv/dts/fu540-c000-u-boot.dtsi         |  14 +++
>> >  .../dts/hifive-unleashed-a00-u-boot.dtsi      |   6 +
>> >  board/sifive/fu540/Kconfig                    |   2 +
>> >  board/sifive/fu540/fu540.c                    | 113 +++++++-----------
>> >  4 files changed, 62 insertions(+), 73 deletions(-)  create mode
>> > 100644 arch/riscv/dts/fu540-c000-u-boot.dtsi
>> >  create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
>> >
>> > diff --git a/arch/riscv/dts/fu540-c000-u-boot.dtsi
>> > b/arch/riscv/dts/fu540-c000-u-boot.dtsi
>> > new file mode 100644
>> > index 0000000000..31fd113c7d
>> > --- /dev/null
>> > +++ b/arch/riscv/dts/fu540-c000-u-boot.dtsi
>> > @@ -0,0 +1,14 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>> > +/*
>> > + * (C) Copyright 2019 SiFive, Inc
>>
>> nits: 2020?

This is something I have written in December,2019. 
V1 patch also submitted in 2019, so i think it's fine to have 2019 here.

>>
>> > + */
>> > +
>> > +/ {
>> > +       soc {
>> > +               otp: otp at 10070000 {
>> > +                       compatible = "sifive,fu540-otp";
>> > +                       reg = <0x0 0x10070000 0x0 0x0FFF>;
>> > +                       fuse-count = <0x1000>;
>>
>> Add status = "disabled" here?
>
>After reviewing patch 5 in this series, I think we can leave without adding
>"status" property here.
>
>>
>> > +               };
>> > +       };
>> > +};
>> > diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
>> > b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
>> > new file mode 100644
>> > index 0000000000..bec0d19134
>> > --- /dev/null
>> > +++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
>> > @@ -0,0 +1,6 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>> > +/*
>> > + * Copyright (C) 2019 SiFive, Inc
>>
>> nits: 2020?

Same as above

>>
>> > + */
>> > +
>> > +#include "fu540-c000-u-boot.dtsi"
>>
>> Add
>>
>> &otp {
>> status = "okay";
>> }
>>
>> here?
>
>After reviewing patch 5 in this series, I think we can leave without adding
>"status" property here.
>
>Regards,
>Bin