[PATCH 0/3] cmd: add driver, fs and part type listing commands

Simon Glass sjg at chromium.org
Tue Mar 17 17:11:57 CET 2020


Hi Neil,

On Tue, 17 Mar 2020 at 08:09, Niel Fourie <lusus at denx.de> wrote:
>
> This series adds commands for listing the supported partition tables,
> listing supported filesystems and expands Driver Model listing commands.
>
> The existing "dm drivers" command, which lists the DM drivers and their
> compatibility strings, segmentation faulted on drivers for which of_match
> was unpopulated (which appears to not be uncommon). This was fixed, and
> the command was renamed "dm compat", and a new more extensive "dm drivers"
> command was added, which list all DM drivers and for each, their uclass
> id, uclass driver and the device names for active driver instances. The
> purpose is show available drivers, but also to highlight unused drivers
> or drivers with uclass ids without uclass drivers, etc.
>
> The following commands were added:
> -"part types", lists partition tables supported
> -"fstypes", lists filesystem types supported
> -"dm compat", lists drivers and their compatibility strings (equivalent
>   to existing "dm drivers" command)
> -"dm drivers", lists all DM drivers, and for each their uclass id,
>   uclass driver and the device names for active driver instances.
> -"dm static", lists all DM drivers which use static platform data
>   (instead of the device tree).
>
> These patches were tested in the Sandbox and on the Wandboard
> i.MX6Quad Board rev B1.

This all looks very useful thank you. Can you please add sandbox tests
for the commands?

For an example, see
https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/blob/coral-working/test/dm/acpi.c

The test is dm_test_acpi_cmd_items()

Regards,
Simon


>
> Niel Fourie (3):
>   cmd: part: Add subcommand to list supported partition tables
>   cmd: fs: Add command to list supported fs types
>   cmd: dm: Fixed/Added DM driver listing subcommands
>
>  cmd/dm.c            | 24 ++++++++++++++++--
>  cmd/fs.c            | 11 +++++++++
>  cmd/part.c          | 27 ++++++++++++++++++--
>  drivers/core/dump.c | 60 ++++++++++++++++++++++++++++++++++++++++++++-
>  fs/fs.c             | 20 +++++++++++++++
>  include/dm/util.h   |  6 +++++
>  include/fs.h        |  5 ++++
>  7 files changed, 148 insertions(+), 5 deletions(-)
>
> --
> 2.24.1
>


More information about the U-Boot mailing list