[PATCH 3/3] cmd: dm: Fixed/Added DM driver listing subcommands

[Tom Rini]

On Wed, Mar 18, 2020 at 01:22:03PM +0100, Niel Fourie wrote:
> Hi Tom,
> 
> On 3/17/20 7:51 PM, Sean Anderson wrote:
> > On 3/17/20 10:09 AM, Niel Fourie wrote:
> > > Renamed dm "drivers" subcommand to "compat" (as it listed
> > > compatibility strings) and prevent it from segfaulting when
> > > drivers have no of_match populated.
> > > 
> > > Added a new "drivers" subcommand to dump a list of all known DM
> > > drivers and for each, their uclass id, uclass driver and names of
> > > attached devices.
> > > 
> > > Added a new "static" subcommand to dump a list of DM drivers with
> > > statically defined platform data.
> > > 
> > > Signed-off-by: Niel Fourie <lusus at denx.de>
> > > CC: Simon Glass <sjg at chromium.org>
> > > ---
> > >   cmd/dm.c            | 24 ++++++++++++++++--
> > >   drivers/core/dump.c | 60 ++++++++++++++++++++++++++++++++++++++++++++-
> > >   include/dm/util.h   |  6 +++++
> > >   3 files changed, 87 insertions(+), 3 deletions(-)
> > > 
> <snip>
> In drivers/core/dump.c:
> > > -void dm_dump_drivers(void)
> > > +void dm_dump_driver_compat(void)
> > >   {
> > >   	struct driver *d = ll_entry_start(struct driver, driver);
> > >   	const int n_ents = ll_entry_count(struct driver, driver);
> > > @@ -107,6 +107,9 @@ void dm_dump_drivers(void)
> > >   	puts("Driver                Compatible\n");
> > >   	puts("--------------------------------\n");
> > >   	for (entry = d; entry < d + n_ents; entry++) {
> > > +		if (!entry->of_match) {
> > > +			continue;
> > > +		}
> > 
> > This should have been fixed in version 2 of the patch [1].
> > 
> > [1] https://patchwork.ozlabs.org/patch/1234460/
> > 
> 
> Should I rebase my series on the version 2 of the above patch, or should I
> simply include that change in my series instead? Thanks in advance!

Please rebase on top of, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200318/4b6b7c8c/attachment.sig>