[PATCH 12/12] net: smc911x: Add DM support

[Marek Vasut]

On 3/17/20 7:55 AM, Masahiro Yamada wrote:
> On Mon, Mar 16, 2020 at 2:01 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>>
>> Add support for U-Boot DM and DT probing. Furthermore, build the
>> SMC911x standalone EEPROM example only for the non-DM case, as it
>> is not converted yet.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
>> Cc: Joe Hershberger <joe.hershberger at ni.com>
>> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>> ---
>>  board/renesas/blanche/blanche.c |   2 +
> 
> 
> Do you need to touch this board in the same commit?
> It is unclear to me why.

Nope, that should be separate.

> One more thing, CONFIG_SMC911X_BASE is only used for
> non DM_ETH case.
> 
> So, can you hide this config option?
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 4d1013c98466..dcda139156f0 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -390,6 +390,7 @@ if SMC911X
> 
>  config SMC911X_BASE
>         hex "SMC911X Base Address"
> +       depends on !DM_ETH
>         help
>           Define this to hold the physical address
>           of the device (I/O space)
> 
> 
> Lastly, mismatch between From: and Signed-off-by.
> 
> Without "+renesas" in From,
> With "+renesas" in Signed-off-by.

Do you have a git config to handle that correctly with gmail ?

-- 
Best regards,
Marek Vasut