[PATCH v7 10/14] xhci: mediatek: Add support for MTK xHCI host controller

[Chunfeng Yun]

On Fri, 2020-05-01 at 23:00 +0530, Jagan Teki wrote:
> On Wed, Apr 29, 2020 at 11:46 AM Chunfeng Yun <chunfeng.yun at mediatek.com> wrote:
> >
> > This patch is used to support the on-chip xHCI controller on
> > MediaTek SoCs, currently control/bulk/interrupt transfers are
> > supported.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> > Reviewed-by: Weijie Gao <weijie.gao at mediatek.com>
...
> > +int xhci_mtk_phy_setup(struct mtk_xhci *mtk)
> > +{
> > +       struct udevice *dev = mtk->dev;
> > +       struct phy_bulk *phys = &mtk->phys;
> > +       int ret;
> > +
> > +       ret = generic_phy_get_bulk(dev, phys);
> > +       if (ret)
> > +               return ret;
> > +
> > +       ret = generic_phy_init_bulk(phys);
> > +       if (ret)
> > +               return ret;
> > +
> > +       ret = generic_phy_power_on_bulk(phys);
> > +       if (ret)
> > +               generic_phy_exit_bulk(phys);
> > +
> > +       return ret;
> > +}
> > +
> > +void xhci_mtk_phy_shutdown(struct mtk_xhci *mtk)
> > +{
> > +       generic_phy_power_off_bulk(&mtk->phys);
> > +       generic_phy_exit_bulk(&mtk->phys);
> > +}
> 
> Hope these are local functions, if yes mark it as static.
Ok, thanks
> 
> otherwise,
> 
> Reviewed-by: Jagan Teki <jagan at amarulasolutions.com>