[PATCH] cmd: efidebug: fix a wrong handling of arguments

AKASHI Takahiro takahiro.akashi at linaro.org
Fri May 8 07:50:47 CEST 2020


Coverity detected a dead code, but actually there is a bug in a check
against a number of arguments. So simply fix it.

Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
Reported-by: Coverity (CID 300330)
---
 cmd/efidebug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 70aba446a937..56bf9af77248 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -606,7 +606,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
 				+ sizeof(struct efi_device_path); /* for END */
 
 	/* optional data */
-	if (argc < 6)
+	if (argc == 6)
 		lo.optional_data = NULL;
 	else
 		lo.optional_data = (const u8 *)argv[6];
-- 
2.25.2



More information about the U-Boot mailing list