[PATCH] efi_loader: variable: fix an reachable statement

AKASHI Takahiro takahiro.akashi at linaro.org
Fri May 8 07:51:01 CEST 2020


The code should jump into error recovery instead of just returning
an error.

Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
Reported-by: Coverity (CID 300332)
---
 lib/efi_loader/efi_variable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index 5b86b77c6660..f40b194b13bf 100644
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -1094,7 +1094,7 @@ efi_status_t EFIAPI efi_set_variable_common(u16 *variable_name,
 	if (append) {
 		old_data = malloc(old_size);
 		if (!old_data) {
-			return EFI_OUT_OF_RESOURCES;
+			ret = EFI_OUT_OF_RESOURCES;
 			goto err;
 		}
 		ret = EFI_CALL(efi_get_variable(variable_name, vendor,
-- 
2.25.2



More information about the U-Boot mailing list