[PATCH 4/8] drivers: ddr: imx8m: add print for DRAM rate

[Adam Ford]

On Mon, May 11, 2020 at 9:13 AM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Peng,
>
> On Mon, May 11, 2020 at 6:30 AM Peng Fan <peng.fan at nxp.com> wrote:
> >
> > From: Ye Li <ye.li at nxp.com>
> >
> > Enable print to show the DRAM rate of current setting and training
> > result.

I am not a fan of this.

> >
> > Reviewed-by: Peng Fan <peng.fan at nxp.com>
> > Signed-off-by: Ye Li <ye.li at nxp.com>
> > Signed-off-by:  Peng Fan <peng.fan at nxp.com>
>
> This is basically a revert from:
>
> commit 0d3bc81391ac031758affdb0811bc9c8b905978c
> Author: Fabio Estevam <festevam at gmail.com>
> Date:   Wed Dec 11 17:37:09 2019 -0300
>
>     imx8m: ddr_init: Move ddr_init() messages to debug level
>
>     Currently inside ddr_init() there is a mix of printf() and debug()
>     level messages.
>
>     Since this type of information is useful for debug purposes,
>     convert all of them to debug level for consistency.
>
>     Signed-off-by: Fabio Estevam <festevam at gmail.com>
>     Reviewed-by: Peng Fan <peng.fan at nxp.com>
>
> In the normal boot cases I don't think these messages are helpful.

I would agree.  As a user, I don't think most people will want to know
this, and it creates a bunch of chatter.  For people who want it,
enable the debug.

>
> > diff --git a/drivers/ddr/imx/imx8m/ddrphy_utils.c b/drivers/ddr/imx/imx8m/ddrphy_utils.c
> > index 9ac7ca923c..9d2378d7dd 100644
> > --- a/drivers/ddr/imx/imx8m/ddrphy_utils.c
> > +++ b/drivers/ddr/imx/imx8m/ddrphy_utils.c
> > @@ -97,7 +97,7 @@ int wait_ddrphy_training_complete(void)
> >                         debug("Training PASS\n");
> >                         return 0;
> >                 } else if (mail == 0xff) {
> > -                       debug("Training FAILED\n");
> > +                       printf("Training FAILED\n");
>
> This one is an error message, so I agree that it is useful to have it printed.
I would agree here.

adam