[PATCH v3] i2c: rcar_i2c: Fix i2c read/write errors

Heiko Schocher hs at denx.de
Thu Oct 1 05:37:32 CEST 2020


Hello Lad,

Am 30.09.2020 um 14:24 schrieb Lad Prabhakar:
> commit 7c8f821e ("i2c: rcar_i2c: Set the slave address from
> rcar_i2c_xfer") blindly called rcar_i2c_set_addr() with read argument
> always set to 1 during xfer which introduced read/write errors, whereas
> earlier rcar_i2c_read_common() called rcar_i2c_set_addr() with read set to
> 1 and rcar_i2c_write_common() called rcar_i2c_set_addr() with read set 0.
> 
> Fixes: 7c8f821e ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
> ---
> v2->v3
> * Made sure value of read is ether 0/1 as pointed by Marek
> 
> v1->v2
> * Incorporated suggestion from Heiko
> 
> v1:
>   https://patchwork.ozlabs.org/project/uboot/patch/
>   20200921163353.5540-1-prabhakar.mahadev-lad.rj at bp.renesas.com/

Thanks!

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list