[PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

Rasmus Villemoes rasmus.villemoes at prevas.dk
Mon Oct 12 09:04:28 CEST 2020


On 09/10/2020 15.08, Tom Rini wrote:
> On Wed, Oct 07, 2020 at 12:17:56AM +0200, Rasmus Villemoes wrote:
>> On 07/10/2020 00.02, Simon Glass wrote:
>>>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>
>>> Is there a way to add a test for this?
>>
>> Not that I can think of, other than finding some BE board and hooking it
>> up in some CI. Apparently not very many people use verified boot on BE
>> platforms :( or at least they don't follow upstream U-Boot closely.
> 
> We have tests for verified boot for sandbox.  Can we not expand them to
> run on qemu* including ppce500?

Perhaps. I didn't know sandbox was supposed to be buildable for other
arches than x86ish. I just tried doing the naive thing,

$ export ARCH=powerpc
$ export CROSS_COMPILE=powerpc-linux-gnu-
$ make sandbox_defconfig
$ make -j8
include/config_distro_bootcmd.h:335:3: error: #error "sandbox EFI
support is only supported on ARM and x86"

After trimming the .config to git rid of that, I get a million other
warnings and errors, so that doesn't seem to be the right way.

Can we please apply the patch to unbreak actual boards even if there's
no regression test for it?

Rasmus


More information about the U-Boot mailing list