[PATCH v2] fastboot: getvar: fix partition-size return value
Gary Bisson
gary.bisson at boundarydevices.com
Tue Sep 1 14:51:45 CEST 2020
Hi Sam,
On Tue, Sep 01, 2020 at 01:31:46PM +0300, Sam Protsenko wrote:
> Hi Gary,
>
> On Thu, 27 Aug 2020 at 11:51, Gary Bisson
> <gary.bisson at boundarydevices.com> wrote:
> >
> > The size returned by 'getvar partition-size' should be in bytes, not in
> > blocks as fastboot uses that value to generate empty partition when
> > running format [1].
> >
> > Note that the function was already returning the proper size in bytes
> > for NAND devices (see struct part_info details).
> >
> > [1]
> > https://android.googlesource.com/platform/system/core/+/refs/heads/android10-release/fastboot/fastboot.cpp#1500
> >
> > Signed-off-by: Gary Bisson <gary.bisson at boundarydevices.com>
> > ---
>
> Thank you for the patch, all look good! As I understand from the
> changelog, v2 fixes sunxi build error found by Lukasz?
Indeed it does. The part_info struct for NAND devices was already
returning a size in bytes instead of blocks.
> Other than that:
>
> Reviewed-by: Sam Protsenko <semen.protsenko at linaro.org>
Thanks,
Gary
More information about the U-Boot
mailing list