[PATCH] include: phy: fix NULL pointer check in phy_write()

[Michal Simek]

Hi Tom,

út 18. 8. 2020 v 2:31 odesílatel Thirupathaiah Annapureddy
<thiruan at linux.microsoft.com> napsal:
>
> phy_write() uses bus->write() instead of bus->read(). This means NULL
> pointer pre-check needs to happen on bus->write instead of bus->read.
>
> Signed-off-by: Thirupathaiah Annapureddy <thiruan at linux.microsoft.com>
> ---
>  include/phy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/phy.h b/include/phy.h
> index 1dbbf65111..cbdb10d6fc 100644
> --- a/include/phy.h
> +++ b/include/phy.h
> @@ -205,7 +205,7 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum,
>  {
>         struct mii_dev *bus = phydev->bus;
>
> -       if (!bus || !bus->read) {
> +       if (!bus || !bus->write) {
>                 debug("%s: No bus configured\n", __func__);
>                 return -1;
>         }
> --
> 2.25.2
>

Please also take this patch to your tree.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs