[PATCH] include: phy: fix NULL pointer check in phy_write()

[Tom Rini]

On Tue, Sep 15, 2020 at 04:23:02PM +0200, Michal Simek wrote:
> Hi Tom,
> 
> út 18. 8. 2020 v 2:31 odesílatel Thirupathaiah Annapureddy
> <thiruan at linux.microsoft.com> napsal:
> >
> > phy_write() uses bus->write() instead of bus->read(). This means NULL
> > pointer pre-check needs to happen on bus->write instead of bus->read.
> >
> > Signed-off-by: Thirupathaiah Annapureddy <thiruan at linux.microsoft.com>
> > ---
> >  include/phy.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/phy.h b/include/phy.h
> > index 1dbbf65111..cbdb10d6fc 100644
> > --- a/include/phy.h
> > +++ b/include/phy.h
> > @@ -205,7 +205,7 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum,
> >  {
> >         struct mii_dev *bus = phydev->bus;
> >
> > -       if (!bus || !bus->read) {
> > +       if (!bus || !bus->write) {
> >                 debug("%s: No bus configured\n", __func__);
> >                 return -1;
> >         }
> > --
> > 2.25.2
> >
> 
> Please also take this patch to your tree.

OK, will do.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200915/bf61aa7a/attachment.sig>