[PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support

Heiko Schocher hs at denx.de
Thu Sep 17 15:03:28 CEST 2020


Hello Tom,

Am 17.09.2020 um 14:51 schrieb Tom Rini:
> On Thu, Sep 17, 2020 at 06:27:03AM +0200, Heiko Schocher wrote:
>> Hello Tom,
>>
>> Am 16.09.2020 um 21:01 schrieb Tom Rini:
>>> On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote:
>>>> Hello Mario, Tom,
>>>>
>>>> added Tom to cc ...
>>>>
>>>> Am 08.09.2020 um 07:59 schrieb Heiko Schocher:
>>>>> Hi Mario,
>>>>>
>>>>> Am 17.08.2020 um 07:23 schrieb Heiko Schocher:
>>>>>> Hello Mario,
>>>>>>
>>>>>> Am 27.05.2020 um 14:43 schrieb Heiko Schocher:
>>>>>>>
>>>>>>> This patch series adds DM ethernet support for mpc83xx based
>>>>>>> keymile boards.
>>>>>>>
>>>>>>> Travis build:
>>>>>>> https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214
>>>>>>>
>>>>>>>
>>>>>>> Changes in v2:
>>>>>>> - new in v2
>>>>>>> - remove RFC
>>>>>>> - fixed Codingstyle errors, therefore new patch
>>>>>>>      powerpc, mpc83xx: fix codingstyle issues for qe_io.c
>>>>>>> - moved DM part to drivers/pinctrl
>>>>>>> - add comments from Qiang Zhao:
>>>>>>>      - add device node documentation
>>>>>>>      - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c
>>>>>>>        because using drivers/net/fsl_mdio.c leads in none existent
>>>>>>>        udevice mdio at 3320
>>>>>>>        instead boards with DM ETH support should use now this
>>>>>>>        driver.
>>>>>>> - remove RFC tag
>>>>>>> - add patch which fixes Codingstyle errors in drivers/qe
>>>>>>> - add patch which converts the mpc83xx based boards from
>>>>>>>      keymile to DM_ETH
>>>>>>>
>>>>>>> Heiko Schocher (5):
>>>>>>>      mpc83xx: remove unneeded extern declaration in cpu_init
>>>>>>>      powerpc, qe: fix codingstyle issues for drivers/qe
>>>>>>>      powerpc, qe: add DTS support for parallel I/O ports
>>>>>>>      net, qe: add DM support for QE UEC ethernet
>>>>>>>      mpc83xx, keymile boards: enable DM_ETH and add DTS
>>>>>>>
>>>>>>>     arch/powerpc/cpu/mpc83xx/Kconfig              |    8 +
>>>>>>>     arch/powerpc/cpu/mpc83xx/Makefile             |    2 +
>>>>>>>     arch/powerpc/cpu/mpc83xx/cpu_init.c           |   11 +-
>>>>>>>     arch/powerpc/cpu/mpc83xx/qe_io.c              |   98 +-
>>>>>>>     arch/powerpc/dts/Makefile                     |    8 +
>>>>>>>     arch/powerpc/dts/km8309-uboot.dtsi            |   33 +
>>>>>>>     arch/powerpc/dts/km8321-uboot.dtsi            |   67 +
>>>>>>>     arch/powerpc/dts/km8321.dtsi                  |  220 ++++
>>>>>>>     arch/powerpc/dts/km836x-uboot.dtsi            |   61 +
>>>>>>>     arch/powerpc/dts/km836x.dtsi                  |  182 +++
>>>>>>>     arch/powerpc/dts/kmcoge5ne-uboot.dtsi         |   22 +
>>>>>>>     arch/powerpc/dts/kmcoge5ne.dts                |  320 +++++
>>>>>>>     arch/powerpc/dts/kmeter1-uboot.dtsi           |   42 +
>>>>>>>     arch/powerpc/dts/kmeter1.dts                  |  480 +++++++
>>>>>>>     arch/powerpc/dts/kmopti2.dts                  |  161 +++
>>>>>>>     arch/powerpc/dts/kmsupc5.dts                  |  139 ++
>>>>>>>     arch/powerpc/dts/kmsupm5.dts                  |  129 ++
>>>>>>>     arch/powerpc/dts/kmtegr1.dts                  |  392 ++++++
>>>>>>>     arch/powerpc/dts/kmtepr2.dts                  |  142 ++
>>>>>>>     arch/powerpc/dts/kmtuge1.dts                  |  100 ++
>>>>>>>     arch/powerpc/dts/kmtuxa1.dts                  |  100 ++
>>>>>>>     board/keymile/km83xx/Kconfig                  |   17 +
>>>>>>>     board/keymile/km83xx/MAINTAINERS              |   23 +-
>>>>>>>     board/keymile/km83xx/km83xx.c                 |   64 -
>>>>>>>     configs/kmcoge5ne_defconfig                   |   11 +-
>>>>>>>     configs/kmeter1_defconfig                     |   10 +-
>>>>>>>     configs/kmopti2_defconfig                     |   11 +-
>>>>>>>     configs/kmsupx5_defconfig                     |   10 +-
>>>>>>>     configs/kmtegr1_defconfig                     |   12 +-
>>>>>>>     configs/kmtepr2_defconfig                     |   10 +-
>>>>>>>     configs/tuge1_defconfig                       |   10 +-
>>>>>>>     configs/tuxx1_defconfig                       |   11 +-
>>>>>>>     .../soc/fsl/cpm_qe/qe/ucc.txt                 |   53 +
>>>>>>>     drivers/net/Kconfig                           |    2 +
>>>>>>>     drivers/net/Makefile                          |    1 +
>>>>>>>     drivers/net/qe/Kconfig                        |    9 +
>>>>>>>     drivers/net/qe/Makefile                       |    5 +
>>>>>>>     drivers/net/qe/dm_qe_uec.c                    | 1167 +++++++++++++++++
>>>>>>>     drivers/net/qe/dm_qe_uec.h                    |   22 +
>>>>>>>     drivers/net/qe/dm_qe_uec_phy.c                |  163 +++
>>>>>>>     drivers/net/qe/uccf.c                         |  507 +++++++
>>>>>>>     drivers/net/qe/uccf.h                         |  119 ++
>>>>>>>     drivers/net/qe/uec.h                          |  693 ++++++++++
>>>>>>>     drivers/pinctrl/Kconfig                       |    7 +
>>>>>>>     drivers/pinctrl/Makefile                      |    1 +
>>>>>>>     drivers/pinctrl/pinctrl-qe-io.c               |  255 ++++
>>>>>>>     drivers/qe/qe.c                               |   96 +-
>>>>>>>     drivers/qe/uccf.c                             |  449 ++++---
>>>>>>>     drivers/qe/uccf.h                             |   90 +-
>>>>>>>     drivers/qe/uec.c                              |  598 ++++-----
>>>>>>>     drivers/qe/uec.h                              |  381 +++---
>>>>>>>     drivers/qe/uec_phy.c                          |  334 ++---
>>>>>>>     drivers/qe/uec_phy.h                          |   71 +-
>>>>>>>     include/configs/km/km-mpc832x.h               |   14 -
>>>>>>>     include/configs/km/km-mpc8360.h               |   14 -
>>>>>>>     include/configs/km/km-mpc83xx.h               |   10 -
>>>>>>>     include/fsl_qe.h                              |    3 +
>>>>>>>     57 files changed, 6826 insertions(+), 1144 deletions(-)
>>>>>>>     create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/km8321.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/km836x.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
>>>>>>>     create mode 100644 arch/powerpc/dts/kmeter1.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmopti2.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmsupc5.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmsupm5.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmtegr1.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmtepr2.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmtuge1.dts
>>>>>>>     create mode 100644 arch/powerpc/dts/kmtuxa1.dts
>>>>>>>     create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt
>>>>>>>     create mode 100644 drivers/net/qe/Kconfig
>>>>>>>     create mode 100644 drivers/net/qe/Makefile
>>>>>>>     create mode 100644 drivers/net/qe/dm_qe_uec.c
>>>>>>>     create mode 100644 drivers/net/qe/dm_qe_uec.h
>>>>>>>     create mode 100644 drivers/net/qe/dm_qe_uec_phy.c
>>>>>>>     create mode 100644 drivers/net/qe/uccf.c
>>>>>>>     create mode 100644 drivers/net/qe/uccf.h
>>>>>>>     create mode 100644 drivers/net/qe/uec.h
>>>>>>>     create mode 100644 drivers/pinctrl/pinctrl-qe-io.c
>>>>>>
>>>>>> gentle ping!
>>>>>>
>>>>>> I got no reviews, comments for this patchseries ...
>>>>>>
>>>>>> any comments?
>>>>>
>>>>> ping?
>>>>>
>>>>> I have a rebased version in the meantime, but I would wait for
>>>>> any comments...
>>>>
>>>> gentle ping...
>>>>
>>>> @Tom: Mario seems to busy .. how to proceed here with this patches?
>>>
>>> Can you put together something for me to pull in to -next please?
>>> Thanks!
>>
>> Ok, pushed them to a repo on github:
>>
>> https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel
>>
>> started travis build for this branch:
>> https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421
>>
>> If all builds fine, I can send a pull request ... is it ok for
>> you if I push this branch to u-boot-i2c kmcoge5ne-dm-ethernet-devel?
> 
> Works for me, thanks!

Ok, travis build is fine, so here the pull request:

The following changes since commit bd4e8944cf7e36f8ad39466c40f8fc197c9df1c5:

   Merge tag 'ti-v2021.01-next' of https://gitlab.denx.de/u-boot/custodians/u-boot-ti into next 
(2020-09-15 15:22:00 -0400)

are available in the Git repository at:

   https://gitlab.denx.de/u-boot/custodians/u-boot-i2c.git tags/for-v2021.01-next

for you to fetch changes up to 7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9:

   mpc83xx, keymile boards: enable DM_ETH and add DTS (2020-09-17 06:09:54 +0200)

----------------------------------------------------------------
mpc83xx, keymile boards: enable DM_ETH and add DTS
   - mpc83xx: remove unneeded extern declaration in cpu_init
   - powerpc, qe: fix codingstyle issues for drivers/qe
   - powerpc, qe: add DTS support for parallel I/O ports
   - net, qe: add DM support for QE UEC ethernet
   - add DTS for all mpc83xx based boards from keymile
     mainly they are not mainlined to linux.
   - add u-boot specific dtsi 

   - add stdout-path 

   - add missing ucc4 par_io definitions, which were
     in board code, but not in linux DTS
   - remove not used ethernet nodes

----------------------------------------------------------------
Heiko Schocher (5):
       mpc83xx: remove unneeded extern declaration in cpu_init
       powerpc, qe: fix codingstyle issues for drivers/qe
       powerpc, qe: add DTS support for parallel I/O ports
       net, qe: add DM support for QE UEC ethernet
       mpc83xx, keymile boards: enable DM_ETH and add DTS

  arch/powerpc/cpu/mpc83xx/Kconfig                   |    8 +
  arch/powerpc/cpu/mpc83xx/Makefile                  |    2 +
  arch/powerpc/cpu/mpc83xx/cpu_init.c                |   11 +-
  arch/powerpc/cpu/mpc83xx/qe_io.c                   |   98 +++++++---
  arch/powerpc/dts/Makefile                          |    8 +
  arch/powerpc/dts/km8309-uboot.dtsi                 |   33 ++++
  arch/powerpc/dts/km8321-uboot.dtsi                 |   67 +++++++
  arch/powerpc/dts/km8321.dtsi                       |  220 +++++++++++++++++++++
  arch/powerpc/dts/km836x-uboot.dtsi                 |   61 ++++++
  arch/powerpc/dts/km836x.dtsi                       |  182 ++++++++++++++++++
  arch/powerpc/dts/kmcoge5ne-uboot.dtsi              |   22 +++
  arch/powerpc/dts/kmcoge5ne.dts                     |  320 +++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmeter1-uboot.dtsi                |   42 ++++
  arch/powerpc/dts/kmeter1.dts                       |  480 
++++++++++++++++++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmopti2.dts                       |  161 ++++++++++++++++
  arch/powerpc/dts/kmsupc5.dts                       |  139 ++++++++++++++
  arch/powerpc/dts/kmsupm5.dts                       |  129 +++++++++++++
  arch/powerpc/dts/kmtegr1.dts                       |  392 ++++++++++++++++++++++++++++++++++++++
  arch/powerpc/dts/kmtepr2.dts                       |  142 ++++++++++++++
  arch/powerpc/dts/kmtuge1.dts                       |  100 ++++++++++
  arch/powerpc/dts/kmtuxa1.dts                       |  100 ++++++++++
  board/keymile/km83xx/Kconfig                       |   17 ++
  board/keymile/km83xx/MAINTAINERS                   |   23 ++-
  board/keymile/km83xx/km83xx.c                      |   64 -------
  configs/kmcoge5ne_defconfig                        |   11 +-
  configs/kmeter1_defconfig                          |   10 +-
  configs/kmopti2_defconfig                          |   11 +-
  configs/kmsupx5_defconfig                          |   10 +-
  configs/kmtegr1_defconfig                          |   12 +-
  configs/kmtepr2_defconfig                          |   10 +-
  configs/tuge1_defconfig                            |   10 +-
  configs/tuxx1_defconfig                            |   11 +-
  doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt |   53 ++++++
  drivers/net/Kconfig                                |    2 +
  drivers/net/Makefile                               |    1 +
  drivers/net/qe/Kconfig                             |    9 +
  drivers/net/qe/Makefile                            |    5 +
  drivers/net/qe/dm_qe_uec.c                         | 1167 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/net/qe/dm_qe_uec.h                         |   22 +++
  drivers/net/qe/dm_qe_uec_phy.c                     |  163 ++++++++++++++++
  drivers/net/qe/uccf.c                              |  507 
+++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/net/qe/uccf.h                              |  119 ++++++++++++
  drivers/net/qe/uec.h                               |  693 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
  drivers/pinctrl/Kconfig                            |    7 +
  drivers/pinctrl/Makefile                           |    1 +
  drivers/pinctrl/pinctrl-qe-io.c                    |  255 +++++++++++++++++++++++++
  drivers/qe/Kconfig                                 |    2 +-
  drivers/qe/qe.c                                    |   96 +++++-----
  drivers/qe/uccf.c                                  |  449 +++++++++++++++++++++++++++----------------
  drivers/qe/uccf.h                                  |   90 ++++-----
  drivers/qe/uec.c                                   |  598 
++++++++++++++++++++++++++++-----------------------------
  drivers/qe/uec.h                                   |  381 ++++++++++++++++---------------------
  drivers/qe/uec_phy.c                               |  334 ++++++++++++++++----------------
  drivers/qe/uec_phy.h                               |   71 +++----
  include/configs/km/km-mpc832x.h                    |   14 --
  include/configs/km/km-mpc8360.h                    |   14 --
  include/configs/km/km-mpc83xx.h                    |   10 -
  include/fsl_qe.h                                   |    3 +
  58 files changed, 6827 insertions(+), 1145 deletions(-)
  create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi
  create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi
  create mode 100644 arch/powerpc/dts/km8321.dtsi
  create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi
  create mode 100644 arch/powerpc/dts/km836x.dtsi
  create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi
  create mode 100644 arch/powerpc/dts/kmcoge5ne.dts
  create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi
  create mode 100644 arch/powerpc/dts/kmeter1.dts
  create mode 100644 arch/powerpc/dts/kmopti2.dts
  create mode 100644 arch/powerpc/dts/kmsupc5.dts
  create mode 100644 arch/powerpc/dts/kmsupm5.dts
  create mode 100644 arch/powerpc/dts/kmtegr1.dts
  create mode 100644 arch/powerpc/dts/kmtepr2.dts
  create mode 100644 arch/powerpc/dts/kmtuge1.dts
  create mode 100644 arch/powerpc/dts/kmtuxa1.dts
  create mode 100644 doc/device-tree-bindings/soc/fsl/cpm_qe/qe/ucc.txt
  create mode 100644 drivers/net/qe/Kconfig
  create mode 100644 drivers/net/qe/Makefile
  create mode 100644 drivers/net/qe/dm_qe_uec.c
  create mode 100644 drivers/net/qe/dm_qe_uec.h
  create mode 100644 drivers/net/qe/dm_qe_uec_phy.c
  create mode 100644 drivers/net/qe/uccf.c
  create mode 100644 drivers/net/qe/uccf.h
  create mode 100644 drivers/net/qe/uec.h
  create mode 100644 drivers/pinctrl/pinctrl-qe-io.c

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list