[BUG] sandbox: './u-boot -l ' fails

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Sep 29 13:47:12 CEST 2020


Am 29. September 2020 13:12:25 MESZ schrieb Wolfgang Denk <wd at denx.de>:
>Dear Heinrich,
>
>In message <cab32aa2-0423-c966-47e1-a6f59411b0d1 at gmx.de> you wrote:
>>
>> As we always try to use the same definition in U-Boot as in glibc we
>> should really replace getc() by another symbol, e.g. chget() so that
>we
>> avoid confusion.
>
>We should not invent any new names when there are existing good
>alterntives.
>
>Why not use getchar()?
>
>Quote fgetc(3) man page:
>
>...
>       int getchar(void);
>...
>       getchar() is equivalent to getc(stdin).
>...
>
>Best regards,
>
>Wolfgang Denk


Hello Wolfgang,

please, have a look at http://patchwork.ozlabs.org/project/uboot/patch/20200928234514.124945-1-xypron.glpk@gmx.de/

Is such a #define the way to go or should we globally rename getc?

Best regards

Heinrich



More information about the U-Boot mailing list