[PATCH v3 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra board support

[Luka Kovacic]

Hello Gerald,

On Sat, Aug 14, 2021 at 9:59 AM Gérald Kerma <gandalf at gk2.net> wrote:
>
> Héllo,
> > Message: 2
> > Date: Fri, 13 Aug 2021 12:03:57 +0200
> > From: Luka Kovacic<luka.kovacic at sartura.hr>
> > To: Pali Roh?r<pali at kernel.org>
> > Cc:u-boot at lists.denx.de, Robert Marko<robert.marko at sartura.hr>,
> >       Luka Perkov<luka.perkov at sartura.hr>, Marek Behun
> >       <marek.behun at nic.cz>,sr at denx.de,sjg at chromium.org,
> >       patrick.delaunay at foss.st.com,xypron.glpk at gmx.de
> > Subject: Re: [PATCH v3 3/3] arm: mvebu: Initial ESPRESSOBin-Ultra
> >       board support
> > Message-ID:
> >       <CADZsf3buKpgUJq_2yP1zakQbf0Hoq_4oPLdi69_d+qoR+Hbn0w at mail.gmail.com>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > Hello Pali,
> >
> > On Fri, Aug 13, 2021 at 11:27 AM Pali Roh?r<pali at kernel.org>  wrote:
> >> On Friday 13 August 2021 01:39:38 Luka Kovacic wrote:
> >>> Add initial support for the ESPRESSOBin-Ultra board from Globalscale
> >>> Technologies, Inc.
> >>>
> >>> The board is based on the 64-bit dual-core Marvell Armada 3720 SoC.
> >>> Peripherals:
> >>>   - 5 Gigabit Ethernet ports (WAN has PoE, up to 30W, Topaz 6341 switch)
> >>>   - RTC clock (PCF8563)
> >>>   - USB 3.0 port
> >>>   - USB 2.0 port
> >>>   - 4x LED
> >>>   - UART over Micro-USB
> >>>   - M.2 slot (2280)
> >>>   - Mini PCI-E slot
> >>>
> >>> Additionally, automatic import of the Marvell hw_info parameters is
> >>> enabled via the recently added mac command for A37XX platforms.
> >>> The parameters stored in Marvell hw_info are usually the board serial
> >>> number and MAC addresses.
> >>>
> >>> Signed-off-by: Luka Kovacic<luka.kovacic at sartura.hr>
> >>> Cc: Luka Perkov<luka.perkov at sartura.hr>
> >>> Cc: Robert Marko<robert.marko at sartura.hr>
> >>> ---
> >>>   arch/arm/dts/Makefile                         |   1 +
> >>>   .../arm/dts/armada-3720-espressobin-ultra.dts | 114 ++++++++++
> >>>   arch/arm/dts/armada-3720-espressobin.dts      | 199 +----------------
> >>>   arch/arm/dts/armada-3720-espressobin.dtsi     | 210 ++++++++++++++++++
> >>>   board/Marvell/mvebu_armada-37xx/MAINTAINERS   |   8 +
> >>>   board/Marvell/mvebu_armada-37xx/board.c       |  92 +++++++-
> >>>   .../mvebu_espressobin-ultra-88f3720_defconfig |  93 ++++++++
> >>>   7 files changed, 514 insertions(+), 203 deletions(-)
> >>>   create mode 100644 arch/arm/dts/armada-3720-espressobin-ultra.dts
> >>>   create mode 100644 arch/arm/dts/armada-3720-espressobin.dtsi
> >>>   create mode 100644 configs/mvebu_espressobin-ultra-88f3720_defconfig
> >> ...
>
> Thanks, all, for this job.
>
> I am available for testing (if needed) on EspressoBin V7, with eMMC, and
> EspressoBin Ultra.

Thanks for offering your help. Can you test the following patchset
(v4), when it's out,
as some implementation issues still have to be resolved here?

>
> I have issue on EspressoBin Ultra, with the v2 patch for
> EspressoBin-Ultra, on OpenWrt 21.02-RC, fw_printenv do not works... (CRC
> Error)
> I have the same issue with the Marvell (GlobalScale) u-Boot, factory and
> upgraded version.

Did you specify the U-Boot environment location correctly in the fw_printenv
config?

> Environments variables are correctly managed from the u-Boot itself.
>
> Regards,
> Gérald Kerma
>
> PS : I am only registered to the digest, so I hope my mail will not be
> disturbing...

Kind regards,
Luka