[PATCH] cmd: pwm: Rework argc sanity checking

Tom Rini trini at konsulko.com
Thu Feb 25 14:24:43 CET 2021


On Tue, Jan 26, 2021 at 11:44:37AM -0500, Tom Rini wrote:

> Currently, we check argc in a number of places to make sure that we have
> all of the required arguments for each of the pwm sub-commands.
> However, there's at least one place where we've got dead code as we'll
> never have argc == 0, due to checking that argc was at least 4 earlier
> and having only subtracted 3.  Rework things so that when we have
> determined our subcommand make sure we have the right number of
> arguments for it, or error out.  This means we can stop checking against
> argc again later.
> 
> Reported-by: Coverity (CID: 316601)
> Cc: Pragnesh Patel <pragnesh.patel at sifive.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210225/1a20bba3/attachment.sig>


More information about the U-Boot mailing list