[PATCH 2/2] mx7ulp: add base SPL support for mx7ulp

[Oleksandr Suvorov]

Hi Fabio,

On Tue, Sep 7, 2021 at 10:03 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Oleksandr,
>
> On Tue, Sep 7, 2021 at 11:59 AM Oleksandr Suvorov
> <oleksandr.suvorov at foundries.io> wrote:
>
> >  arch/arm/Makefile              |  2 +-
> >  arch/arm/mach-imx/Makefile     |  2 +-
> >  arch/arm/mach-imx/mx7ulp/soc.c |  2 +-
> >  arch/arm/mach-imx/spl.c        | 12 ++++++--
> >  include/configs/imx7ulp_spl.h  | 52 ++++++++++++++++++++++++++++++++++
>
> Could you also include a user for this header file as part of the series?

A user is the EA imx7ulp com board (TARGET_MX7ULP_COM), upstreaming
all stuff for
SPL on that board is impossible right now due to limited resources -
there is a lot of work
for splitting monolithic commits. I can't predict how much time
preparing the SPL-version
of the EA imx7ulp com board will take.
The current patchset is generic for any 7ulp-based board so I think it
will be useful in itself.

> > + * see figure 35-5 in i.MX 7ULP Reference manual:
> > + *  - IMX7ULP A7 OCRAM free area RAM is from 0x2F010000 to 0x2F03FF00.
> > + *  - Set the stack at the end of the free area section, at 0x2003FEB8.
> > + *  - The BOOT ROM loads what they consider the firmware image
> > + *    which consists of a 4K header in front of us that contains the IVT, DCD
> > + *    and some padding thus 'our' max size is really 0x2F03FF00 - 0x2F011000.
> > + *    187KB is more then enough for the SPL.
>
> s/then/than

Thanks, good catch! I'll fix it in the next version.

> > +/* Define the payload for FAT/EXT support */
> > +#if CONFIG_IS_ENABLED(SPL_FS_FAT) || CONFIG_IS_ENABLED(SPL_FS_EXT4)
> > +# if CONFIG_IS_ENABLED(OF_CONTROL)
> > +#  define CONFIG_SPL_FS_LOAD_PAYLOAD_NAME      "u-boot-dtb.img"
> > +# else
> > +#  define CONFIG_SPL_FS_LOAD_PAYLOAD_NAME      "u-boot.img"
>
> You could drop the ifdef and assume OF_CONTROL is always present.

Sure, thanks!

-- 
Best regards,

Oleksandr Suvorov
Software Engineer
W: www.foundries.io