[PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status

Stefan Roese sr at denx.de
Fri Sep 10 08:58:27 CEST 2021


On 07.09.21 17:27, Marek Behún wrote:
> Use dev_dbg() instead of dev_err() in pcie_advk_check_pio_status().
> 
> For example CRS is not an error status, it just says that the request
> should be retried.
> 
> Without this, U-Boot spams the terminal with
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x100000
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x108000
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x110000
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x120000
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x128000
>    pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x130000
>    ...
> when a device is not connected to a PCIe switch (Unsupported Request
> from the switch).
> 
> Signed-off-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   drivers/pci/pci-aardvark.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 74797e984c..cf6e30f936 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -327,7 +327,7 @@ static int pcie_advk_check_pio_status(struct pcie_advk *pcie,
>   	else
>   		str_posted = "Posted";
>   
> -	dev_err(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
> +	dev_dbg(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
>   		str_posted, strcomp_status, reg,
>   		advk_readl(pcie, PIO_ADDR_LS));
>   
> 


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list