[PATCH u-boot-marvell] arm: a37xx: pci: Don't spam about PIO Response Status

Pali Rohár pali at kernel.org
Fri Sep 10 00:10:21 CEST 2021


On Tuesday 07 September 2021 17:27:08 Marek Behún wrote:
> Use dev_dbg() instead of dev_err() in pcie_advk_check_pio_status().
> 
> For example CRS is not an error status, it just says that the request
> should be retried.
> 
> Without this, U-Boot spams the terminal with
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x100000
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x108000
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x110000
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x120000
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x128000
>   pcie_advk pcie at d0070000: Non-posted PIO Response Status: UR, 0xc80 @ 0x130000
>   ...
> when a device is not connected to a PCIe switch (Unsupported Request
> from the switch).
> 
> Signed-off-by: Marek Behún <marek.behun at nic.cz>

Reviewed-by: Pali Rohár <pali at kernel.org>

> ---
>  drivers/pci/pci-aardvark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 74797e984c..cf6e30f936 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -327,7 +327,7 @@ static int pcie_advk_check_pio_status(struct pcie_advk *pcie,
>  	else
>  		str_posted = "Posted";
>  
> -	dev_err(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
> +	dev_dbg(pcie->dev, "%s PIO Response Status: %s, %#x @ %#x\n",
>  		str_posted, strcomp_status, reg,
>  		advk_readl(pcie, PIO_ADDR_LS));
>  
> -- 
> 2.32.0
> 


More information about the U-Boot mailing list