RFC: exclude partitions from efi_selftest

Michael Lawnick ml.lawnick at gmx.de
Thu Sep 16 09:15:22 CEST 2021


Am 16.09.2021 um 09:12 schrieb AKASHI Takahiro:
> On Wed, Sep 15, 2021 at 05:06:09PM +0200, Michael Lawnick wrote:
>> Am 15.09.2021 um 13:36 schrieb Michael Lawnick:
>>> Am 15.09.2021 um 13:22 schrieb Heinrich Schuchardt:
>>>>
>>>>
>>>> Am 15. September 2021 12:54:06 MESZ schrieb Michael Lawnick <ml.lawnick at gmx.de>:
>>>>> Am 15.09.2021 um 12:42 schrieb Heinrich Schuchardt:
>>>>>
>>>>>> Could you, please send the complete output starting with 'bootefi selftest'.
>>>>>
>>>>> ASIM-CN10KAS> setenv efi_selftest block device
>>>>> ASIM-CN10KAS> bootefi selftest
>>>>>
>>>>> Testing EFI API implementation
>>>>>
>>>>> Selected test: 'block device'
>>>>>
>>>>> Setting up 'block device'
>>>>> Setting up 'block device' succeeded
>>>>>
>>>>> Executing 'block device'
>>>>> ** Unrecognized filesystem type **
>>>>
>>>> Is the FAT file system enabled in the configuration?
>>>
>>> No
>>>
>>>>
>>>>> lib/efi_selftest/efi_selftest_block_device.c(362):
>>>>> ERROR: Failed to open simple file system protocol
>>>>> lib/efi_selftest/efi_selftest.c(111):
>>>>> ERROR: Executing 'block device' failed
>>>>>
>>>>> Tearing down 'block device'
>>>>> Tearing down 'block device' succeeded
>>>>>
>>>>> Boot services terminated
>>>>>
>>>>> Summary: 1 failures
>>>
>>> Sorry Heinrich, I managed to send below part to only you, so I repeat
>>> for the group:
>>> What might be worth to be noted:
>>> We are working on U-Boot provided by Marvell for upcoming SoC based on
>>> ThunderX. It is rather up to main branch but not the latest version.
>>> Latest change from main:
>>> Author: Patrick Wildt <patrick at blueri.se>
>>> Date:   Wed Oct 7 11:04:33 2020 +0200
>>> efi_loader: fix use after free in receive path
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>>
>>> If you can give a list of relevant modules I can make comparison, but
>>> just updating everything to latest or comparing full source tree won't
>>> be possible.
>>>
>>
>> We have 8 partitions of which no. 5 isn't initialized.
>> I have put a bunch of printf to the code and see that the execute() is
>> done exactly on the partition which is unknown, no other gets touched !?
>
> Just in case,
> "block device" selftest doesn't touch you disk at all.
> Instead, it sets up some memory region as a pseudo block device
> (i.e. block_io_protocol) with fat filesystem, and utilizes it
> for the test execution.
>
> Please, as Heinrich suggested, add CONFIG_FS_FAT, in your U-Boot configuration.
>
Hmm, I didn't understand that as a suggestion, but as a question for his
understanding. Of course I'll give it a try.

KR
Michael




More information about the U-Boot mailing list