[PATCH v4 3/5] sf: Tidy up code to avoid #ifdef

Pratyush Yadav p.yadav at ti.com
Mon Sep 20 13:08:07 CEST 2021


Hi Simon,

On 19/09/21 03:49PM, Simon Glass wrote:
> Update this code to use IS_ENABLED() instead.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> 
> Reviewed-by: Pratyush Yadav <p.yadav at ti.com>

Nitpick: Trailers shouldn't have a blank line between them. I see it for 
this patch and 4/5 as well. It probably doesn't matter, but I wonder if 
it will trip up some tools that work on commit trailers like 
git-interpret-trailers. Something you might want to fix in your 
workflow...

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.


More information about the U-Boot mailing list