[PATCH v4 3/5] sf: Tidy up code to avoid #ifdef

Simon Glass sjg at chromium.org
Fri Sep 24 04:48:35 CEST 2021


Hi Pratyush,

On Mon, 20 Sept 2021 at 05:08, Pratyush Yadav <p.yadav at ti.com> wrote:
>
> Hi Simon,
>
> On 19/09/21 03:49PM, Simon Glass wrote:
> > Update this code to use IS_ENABLED() instead.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > Reviewed-by: Pratyush Yadav <p.yadav at ti.com>
>
> Nitpick: Trailers shouldn't have a blank line between them. I see it for
> this patch and 4/5 as well. It probably doesn't matter, but I wonder if
> it will trip up some tools that work on commit trailers like
> git-interpret-trailers. Something you might want to fix in your
> workflow...

The fix to 'patman status -d <new_branch>' is in mainline but was not
in the tree where I ran this tool, unfortunately.

So hopefully this won't happen again.

Regards,
Simon


More information about the U-Boot mailing list