[PATCH v2] board: gateworks: venice: enable DM_SERIAL

[Michael Nazzareno Trimarchi]

Hi

On Wed, Apr 13, 2022 at 6:09 PM Tim Harvey <tharvey at gateworks.com> wrote:
>
> On Wed, Apr 13, 2022 at 8:56 AM Michael Nazzareno Trimarchi
> <michael at amarulasolutions.com> wrote:
> >
> > Hi Tim
> >
> > On Wed, Apr 13, 2022 at 5:47 PM Tim Harvey <tharvey at gateworks.com> wrote:
> > >
> > > Enable DM_SERIAL.
> > >
> > > Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> > > ---
> > > v2: rebase on imx/master
> > > ---
> > >  configs/imx8mm_venice_defconfig | 2 ++
> > >  configs/imx8mn_venice_defconfig | 2 ++
> > >  2 files changed, 4 insertions(+)
> > >
> > > diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm_venice_defconfig
> > > index dd61ec9b70fb..09f7d8a58ca7 100644
> > > --- a/configs/imx8mm_venice_defconfig
> > > +++ b/configs/imx8mm_venice_defconfig
> > > @@ -110,6 +110,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > >  CONFIG_DM_REGULATOR=y
> > >  CONFIG_DM_REGULATOR_FIXED=y
> > >  CONFIG_DM_REGULATOR_GPIO=y
> > > +CONFIG_DM_SERIAL=y
> > > +# CONFIG_SPL_DM_SERIAL is not set
> > >  CONFIG_MXC_UART=y
> > >  CONFIG_SYSRESET=y
> > >  CONFIG_SPL_SYSRESET=y
> > > diff --git a/configs/imx8mn_venice_defconfig b/configs/imx8mn_venice_defconfig
> > > index c3a96a378553..41898da4aecf 100644
> > > --- a/configs/imx8mn_venice_defconfig
> > > +++ b/configs/imx8mn_venice_defconfig
> > > @@ -108,6 +108,8 @@ CONFIG_SPL_DM_PMIC_MP5416=y
> > >  CONFIG_DM_REGULATOR=y
> > >  CONFIG_DM_REGULATOR_FIXED=y
> > >  CONFIG_DM_REGULATOR_GPIO=y
> > > +CONFIG_DM_SERIAL=y
> > > +# CONFIG_SPL_DM_SERIAL is not set
> > >  CONFIG_MXC_UART=y
> > >  CONFIG_SYSRESET=y
> > >  CONFIG_SPL_SYSRESET=y
> > > --
> > > 2.17.1
> > >
> >
> > Should not select in your board kconfig?
> >
>
> Michael,
>
> I don't think it really matters. The other conversions to DM_SERIAL
> are going in defconfigs as well.

Do we know why without # CONFIG_SPL_DM_SERIAL is not set

board hang?

Michael

>
> Best Regards,
>
> Tim



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com