[PATCH 04/11] arm: mach-k3: Introduce the basic files to support AM62

[Vignesh Raghavendra]

Hi,

On 15/04/22 11:11 pm, Tom Rini wrote:
> On Fri, Apr 15, 2022 at 10:08:32PM +0530, Vignesh Raghavendra wrote:
>>
>>
>> On 15/04/22 9:57 pm, Tom Rini wrote:
>>> On Fri, Apr 15, 2022 at 07:39:24PM +0530, Vignesh Raghavendra wrote:
>>>
>>> [snip]
>>>> diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_init.c
>>>> new file mode 100644
>>>> index 0000000000..ee902a774e
>>>> --- /dev/null
>>>> +++ b/arch/arm/mach-k3/am625_init.c
>>>> @@ -0,0 +1,254 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/*
>>>> + * AM625: SoC specific initialization
>>>> + *
>>>> + * Copyright (C) 2020-2022 Texas Instruments Incorporated - https://www.ti.com/
>>>> + *	Suman Anna <s-anna at ti.com>
>>>> + */
>>>> +
>>>> +#include <common.h>
>>>> +#include <spl.h>
>>>> +#include <asm/io.h>
>>>> +#include <asm/arch/hardware.h>
>>>> +#include <asm/arch/sysfw-loader.h>
>>>> +#include "common.h"
>>>> +#include <dm.h>
>>>> +#include <dm/uclass-internal.h>
>>>> +#include <dm/pinctrl.h>
>>>
>>> Er, common.h twice? 
>>
>> Second one refers to arch/arm/mach-k3/common.h
> 
> OK, lets rename that, and see what info there we can put elsewhere.


arch/arm/mach-k3/common.c which contains set of helper functions that
are used across the K3 family of devices and this header exports those
helpers (and is local to arch/arm/mach-k3/).

We may have split into multiple files according to functions in a
separate series.

> 
>>> Please re-check this, and then also drop common.h
>>> (here and elsewhere) as it only includes other headers and we should
>>> avoid it when possible.  
>>
>> Sure, will do.
>>
>>> In fact, checkpatch.pl complains about both
>>> dm.h and common.h so please address series-wide, thanks.
>>>
>>
>> Unfortunately, it doesn't ;(
> 
> Ah, right.  It only checks for inside of headers.  But still should be
> avoided.
> 

Yes, I will drop including <common.h> in next version.

Regards
Vignesh