[PATCH 2/2] ARM: imx: imx8mn-ddr4-evk: Add ethernet support

[Marek Vasut]

On 2/19/22 14:06, Stefano Babic wrote:

Hi,

[...]

> I have not pushed this patch because I am puzzled. There is nothing 
> wrong in the patch, and I can apply it, but CI fails randomly. There is 
> a warning during compilation of this board, see:
> 
> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/394060
> 
> However, this makes no sense. It looks like that
> 
> +       if (IS_ENABLED(CONFIG_FEC_MXC))
> +               setup_fec();
> 
> This has effect, while during preprocessing of the same file:
> 
> +#if IS_ENABLED(CONFIG_FEC_MXC)
> +static int setup_fec(void)
> 
> it looks like as "deactivated", no idea why. The warning makes no sense 
> by reading the code. And if I build the board locally, with  make or 
> buildman, everything fine - no error at all.  But, even locally, 
> "buildman aarch64" reports this warning. No idea why, but I cannot add 
> this to PR else the breakage goes into Tom's tree.
> 
> Of course, if I drop #if IS_ENABLED(CONFIG_FEC_MXC), everything fine, 
> but it does not means it is a solution.

The ethernet on this board is always present, so maybe that is the 
solution here. Although I also don't know why this failed in the CI and 
not during local build, some clang detail maybe ?