CONFIG_SYS_SPL_ARGS_ADDR

Tom Rini trini at konsulko.com
Tue Jan 11 17:17:00 CET 2022


On Sat, Jan 01, 2022 at 08:00:45PM +0100, Sven Schwermer wrote:

> Hi,
> 
> I'm looking into booting Linux FIT images from SPL. In board_init_r
> (common/spl/spl.c), the boot argument is set to CONFIG_SYS_SPL_ARGS_ADDR if
> defined. When booting a FIT image including a DTB, shouldn't this
> automatically be set to fdt_addr (struct spl_image_info)? This would ensure
> a single point of truth for the DTB address (load address as encoded in the
> FIT image or DTB data start location within the FIT blob if no load address
> is defined) instead of having to set CONFIG_SYS_SPL_ARGS_ADDR to the DTB
> load address.
> 
> I'm not sure whether I'm interpreting this correctly. It would be nice if
> somebody could give some advice.

So, the issue is that we don't enforce environment variables existing
(typically).  The falcon mode code also predates the distro boot stuff
that brought us more consistency in fdt related variable naming and
usage.  Cleanups to the falcon code to make use of this newer code would
be appreciated.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220111/199aab07/attachment.sig>


More information about the U-Boot mailing list