[PATCH] usb: host: ehci-generic: Fix error check

Marek Vasut marex at denx.de
Sat Jul 2 23:42:17 CEST 2022


On 7/2/22 02:45, Andre Przywara wrote:
> Commit 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks
> optional") improved the error check to cover the reset property being
> optional. However this was using the wrong error variable for the
> check, so would now never fail.
> 
> Use the correct error variable for checking the result of
> reset_get_bulk(), to actually report genuine errors.
> 
> Fixes: 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks optional")
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
> Hi,
> 
> apologies for messing up this simple patch of mine last month. I got
> confused by the mixed usage of "ret" and "err" in this function. This
> might endorse some cleanup, but I don't dare to touch this file again,
> especially not that late in the cycle.

Tom, can you pick this patch directly ?

Andre, can you send the ret/err cleanup patch as a follow up , so it can 
be picked after release ?


More information about the U-Boot mailing list