[PATCH] usb: host: ehci-generic: Fix error check
trini at konsulko.com
Sun Jul 3 02:08:27 CEST 2022
On Sat, Jul 02, 2022 at 11:42:17PM +0200, Marek Vasut wrote:
> On 7/2/22 02:45, Andre Przywara wrote:
> > Commit 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks
> > optional") improved the error check to cover the reset property being
> > optional. However this was using the wrong error variable for the
> > check, so would now never fail.
> > Use the correct error variable for checking the result of
> > reset_get_bulk(), to actually report genuine errors.
> > Fixes: 81755b8c20fe ("usb: host: ehci-generic: Make resets and clocks optional")
> > Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> > ---
> > Hi,
> > apologies for messing up this simple patch of mine last month. I got
> > confused by the mixed usage of "ret" and "err" in this function. This
> > might endorse some cleanup, but I don't dare to touch this file again,
> > especially not that late in the cycle.
> Tom, can you pick this patch directly ?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 659 bytes
Desc: not available
More information about the U-Boot