[PATCH 1/5] lib: crypto: add mscode_parser

Jason A. Donenfeld Jason at zx2c4.com
Tue Jul 5 15:13:17 CEST 2022


On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote:
> +	  This option provides support for parsing MicroSoft's Authenticode
> +	  in pkcs7 message.

I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a
wink, but here too... haha ummm. We could change it to "MikeRoweSoft"
instead in honor of the Belmont High School student. But... I think
"Microsoft" is what you're after here.

> +	pr_devel("Data: %zu [%*ph]\n", data_len, (unsigned)(data_len),
> +		 content_data);

That's a weird cast around (data_len), but are you sure you want to keep
that print line in there?
 
Jason


More information about the U-Boot mailing list