[PATCH 1/5] lib: crypto: add mscode_parser

AKASHI Takahiro takahiro.akashi at linaro.org
Wed Jul 6 03:07:05 CEST 2022


On Tue, Jul 05, 2022 at 03:13:17PM +0200, Jason A. Donenfeld wrote:
> On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote:
> > +	  This option provides support for parsing MicroSoft's Authenticode
> > +	  in pkcs7 message.
> I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a
> wink, but here too... haha ummm. We could change it to "MikeRoweSoft"
> instead in honor of the Belmont High School student. But... I think

I have never heard of his name, but

> "Microsoft" is what you're after here.

If so, yes.

> > +	pr_devel("Data: %zu [%*ph]\n", data_len, (unsigned)(data_len),
> > +		 content_data);
> That's a weird cast around (data_len), but are you sure you want to keep
> that print line in there?

My basic policy in importing a file form Linux, as far as lib/crypto/*.c is
concerned, is not to modify the original code unless it's harmful but to add
"#ifndef __UBOOT__" to exclude useless or never-used code so that someone else
other than me can easily synchronize files again in the future.

So even if it looks weird (and checkpatch.pl, which ironically comes from
Linux as well, might raise warnings), I'd like to leave it as it is.

Having said that, if maintainers have a different policy, I don't hesitate
to follow it.

-Takahiro Akashi

> Jason

More information about the U-Boot mailing list